Template: Add tests to ensure all files are part of a template customisation group and all groups are tested #3099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirpedrol
force-pushed
the
test-template-customisation
branch
from
40f01d1
to
ea52f9b
Compare
mirpedrol
force-pushed
the
test-template-customisation
branch
from
a2112fe
to
80b5b74
Compare
mirpedrol
force-pushed
the
test-template-customisation
branch
from
80b5b74
to
283284c
Compare
ewels
approved these changes
Sep 1, 2024
| @@ -31,14 +31,14 @@ params { | |||
|
|
|||
| // Boilerplate options | |||
| outdir = null | |||
| publish_dir_mode = 'copy' | |||
| {% if modules %}publish_dir_mode = 'copy'{% endif %} | |||
There was a problem hiding this comment.
Might be nicer to split these across lines to keep formatting / readability - should be able to use the Jinja - syntax to remove that whitespace on template render.
Needn't be a blocker for merging this though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add testing for template customisation #2340
Note: Will fail until we add all files to a customisation group.All ready to add this test :)