Support version topic channels #3093
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundmiller
force-pushed
the
version-topic-channels
branch
from
4952abb
to
3142b7f
Compare
edmundmiller
force-pushed
the
version-topic-channels
branch
from
3142b7f
to
f5504de
Compare
Otherwise the Workflow is the only Yaml with 4 spaces instead of 2
edmundmiller
force-pushed
the
version-topic-channels
branch
from
f5504de
to
c6d7226
Compare
| @@ -258,7 +258,7 @@ manifest { | |||
| homePage = 'https://github.com/{{ name }}' | |||
| description = """{{ description }}""" | |||
| mainScript = 'main.nf' | |||
| nextflowVersion = '!>=23.04.0' | |||
| nextflowVersion = '!>=23.11.0-edge' | |||
There was a problem hiding this comment.
why not upgrade to the next stable release?
There was a problem hiding this comment.
I figured we would but this was the first release to have topic channels.
Comment on lines
+131
to
+133
| |Workflow: | ||
| | $workflow.manifest.name: ${getWorkflowVersion()} | ||
| | Nextflow: $workflow.nextflow.version |
There was a problem hiding this comment.
what does this syntax do here?
There was a problem hiding this comment.
It strips the white space from the multi line string until the delimiter which by default is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds from nf-core/rnaseq#1115, nf-core/rnaseq#1109 and nf-core/nascent#150
This should support legacy version.ymls, version.ymls with the topic
version_yamlandevaltopics in aversionschannel.PR checklist
CHANGELOG.mdis updateddocsis updated