Template: add option to exclude code linters for custom pipeline template #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirpedrol
force-pushed
the
opt-out-linters
branch
from
e2ecfdd
to
a4c829f
Compare
mashehu
approved these changes
Jul 29, 2024
mirpedrol
commented
Jul 29, 2024
Co-authored-by: Matthias Hörtenhuber <[email protected]>
adamrtalbot
reviewed
Jul 30, 2024
| ".prettierignore", | ||
| ".prettierrc.yml", | ||
| ".github/workflows/fix-linting.yml", | ||
| ], | ||
| } | ||
| # Get list of files we're skipping with the supplied skip keys | ||
| self.skip_paths = set(sp for k in skip_paths for sp in skippable_paths[k]) |
There was a problem hiding this comment.
We should consider the ability to include or exclude specific files via the .nf-core.yml here. Not clear how we should do this yet but it could be a specific key for the .nf-core.yml:
exclude:
- .github/workflows/fix-linting.yml
- .github/workflows/clean-up.yml
include:
- .github/workflows/ci.ymlThis would override the broad categories by the wizard. It could be bypassed when using the TUI for now, consider it an advanced feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2340 and #2342