-
Notifications
You must be signed in to change notification settings - Fork 858
Add metacache query module #8537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
def prefix = task.ext.prefix ?: "${meta.id}" | ||
def input_file = meta.single_end ? reads : "${reads[0]} ${reads[1]} -pairfiles" | ||
""" | ||
dbmeta=`find -L ${db}/ -name "*.meta" | head -n 1` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about groovy code here, instead:
def dbmeta = db.find{ f -> f.name =~ $/\.meta$$/$ }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, did not understand that input db
is a directory. Doesn't it make easier to provide the list of files? Because the output of METACACHE_BUILD
is (currently) not inside a directory. (Then we would have to replace UNTAR
with UNTARFILES
in the tests).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main question is about the db
input being a directory. Should I change the METACACHE_BUILD
module (#8209) to emit a directory instead?
path db | ||
|
||
output: | ||
tuple val(meta), path("*.txt"), emit: mapping_results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be exhaustive (maybe for later), we could add the optional output generated with the option -abundances
.
path "abundances.table", emit: abundances, optional: true
Could be triggered by adding a boolean input val abundances
.
PR checklist
This PR closes: #7852
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda