-
Notifications
You must be signed in to change notification settings - Fork 859
Port gget/gget to nf-test and update #8518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
For search_json_human
|
Well I fixed the singularity issue, but now for some reason one of the tests gives output in conda but not in docker/singularity? |
The muscle test silently fails for docker/singularity with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have anyworking nf-test with a file in input instead of a empty tuple ?
|
||
input: | ||
tuple val(meta), path(files) | ||
|
||
output: | ||
tuple val(meta), path("*[!versions.yml][!${prefix}.${extension}]*"), emit: files, optional: true | ||
tuple val(meta), path("${prefix}.${extension}") , emit: output, optional: true | ||
tuple val(meta), path("*[!versions.yml][!${prefix}.${extension}]*"), emit: files , optional: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this "files" output ?
There aren't generated in the nf-test
process { | ||
""" | ||
input[0] = [ | ||
[id:'test'],// meta map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need to explain that this is a meta map ?
} | ||
} | ||
|
||
// test("search_json_human") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are they commented out ?
} | ||
} | ||
|
||
test("pdb_pdb_7S7U - stub") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have grouped the different stub test together, but not a deal breaker.
PR checklist
Closes #7588
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda