Skip to content

Port gget/gget to nf-test and update #8518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

famosab
Copy link
Contributor

@famosab famosab commented May 20, 2025

PR checklist

Closes #7588

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@famosab famosab mentioned this pull request May 20, 2025
17 tasks
@famosab
Copy link
Contributor Author

famosab commented May 20, 2025

For search_json_human

    12:44:09 - INFO - Fetching results from database: homo_sapiens_core_114_38
    Traceback (most recent call last):
      File "/opt/conda/bin/gget", line 10, in <module>
        sys.exit(main())
                 ~~~~^^
      File "/opt/conda/lib/python3.13/site-packages/gget/main.py", line 2895, in main
        gget_results = search(
            sw_clean_final,
        ...<7 lines>...
            verbose=args.quiet,
        )
      File "/opt/conda/lib/python3.13/site-packages/gget/gget_search.py", line 233, in search
        raise RuntimeError(
            f"The Ensembl server returned the following error: {str(last_exception)}"
        )
    RuntimeError: The Ensembl server returned the following error: 2003 (HY000): Can't connect to MySQL server on 'mysql-eg-publicsql.ebi.ac.uk:5316' (111)

@famosab
Copy link
Contributor Author

famosab commented May 23, 2025

@adamrtalbot

@SPPearce
Copy link
Contributor

Well I fixed the singularity issue, but now for some reason one of the tests gives output in conda but not in docker/singularity?

@SPPearce
Copy link
Contributor

The muscle test silently fails for docker/singularity with:
chmod: changing permissions of '/opt/conda/lib/python3.13/site-packages/gget/bins/Linux/muscle': Operation not permitted present in the .command.err.

Copy link
Contributor

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have anyworking nf-test with a file in input instead of a empty tuple ?


input:
tuple val(meta), path(files)

output:
tuple val(meta), path("*[!versions.yml][!${prefix}.${extension}]*"), emit: files, optional: true
tuple val(meta), path("${prefix}.${extension}") , emit: output, optional: true
tuple val(meta), path("*[!versions.yml][!${prefix}.${extension}]*"), emit: files , optional: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this "files" output ?
There aren't generated in the nf-test

process {
"""
input[0] = [
[id:'test'],// meta map
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to explain that this is a meta map ?

}
}

// test("search_json_human") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are they commented out ?

}
}

test("pdb_pdb_7S7U - stub") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have grouped the different stub test together, but not a deal breaker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nf-test migration: gget/gget
3 participants