Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostile/fetch #6949

Merged
merged 8 commits into from
Nov 7, 2024
Merged

Add hostile/fetch #6949

merged 8 commits into from
Nov 7, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Nov 7, 2024

Closes #6946

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@jfy133
Copy link
Member Author

jfy133 commented Nov 7, 2024

@nf-core-bot fix linting

@jfy133
Copy link
Member Author

jfy133 commented Nov 7, 2024

What the hell.. I generated the snapshots with docker?! 🤔

@jfy133 jfy133 marked this pull request as ready for review November 7, 2024 14:16
modules/nf-core/hostile/fetch/main.nf Show resolved Hide resolved
modules/nf-core/hostile/fetch/meta.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@vagkaratzas vagkaratzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfy133
Copy link
Member Author

jfy133 commented Nov 7, 2024

Thanks @mahesh-panchal @LilyAnderssonLee @vagkaratzas ! Fun watching you race (Mahesh with ninja review, Lili sitting next to me, and Evangelos talking to me on slack ) 😆

@jfy133 jfy133 added this pull request to the merge queue Nov 7, 2024
Merged via the queue into master with commit a2db453 Nov 7, 2024
12 checks passed
@jfy133 jfy133 deleted the new-module-hostile-fetch branch November 7, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: HOSTILE/FETCH
6 participants