-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump ALL gatk4 modules #6917
base: master
Are you sure you want to change the base?
bump ALL gatk4 modules #6917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but failing tests 😭
Great... now I've got 128 failing tests instead of 27. |
This was exactly what I hoped would happen! Thanks for breaking it so quickly! |
It's because you're coming from a fork. I'll make a PR to skip the whole thing if someone does that. |
@edmundmiller, I've applied the renovate comment to all the |
It's definately the gatk4, it doesn't fail with bowtie/align |
This works: ---
# yaml-language-server: $schema=https://raw.githubusercontent.com/nf-core/modules/master/modules/environment-schema.json
channels:
- conda-forge
- bioconda
dependencies:
# renovate: datasource=conda depName=bioconda/gatk4
- bioconda::gatk4=4.5.0.0 4.6.1.0 doesn't 🫠 |
Nice find with the hidden character @edmundmiller! I've managed to fix it for all the tests. |
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda