Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ALL gatk4 modules #6917

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

bump ALL gatk4 modules #6917

wants to merge 47 commits into from

Conversation

matthdsm
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but failing tests 😭

@matthdsm matthdsm requested a review from a team as a code owner November 4, 2024 12:49
@matthdsm
Copy link
Contributor Author

matthdsm commented Nov 7, 2024

Great... now I've got 128 failing tests instead of 27.

@edmundmiller
Copy link
Contributor

Great... now I've got 128 failing tests instead of 27.

This was exactly what I hoped would happen! Thanks for breaking it so quickly!

@edmundmiller
Copy link
Contributor

It's because you're coming from a fork. I'll make a PR to skip the whole thing if someone does that.

@matthdsm
Copy link
Contributor Author

matthdsm commented Nov 8, 2024

@edmundmiller, I've applied the renovate comment to all the environment.yml files but now prettier fails. Any ideas on how to fix it?

@edmundmiller
Copy link
Contributor

It's definately the gatk4, it doesn't fail with bowtie/align

@edmundmiller
Copy link
Contributor

This works:

---
# yaml-language-server: $schema=https://raw.githubusercontent.com/nf-core/modules/master/modules/environment-schema.json
channels:
  - conda-forge
  - bioconda
dependencies:
  # renovate: datasource=conda depName=bioconda/gatk4
  - bioconda::gatk4=4.5.0.0

4.6.1.0 doesn't 🫠

@matthdsm
Copy link
Contributor Author

matthdsm commented Nov 8, 2024

Nice find with the hidden character @edmundmiller! I've managed to fix it for all the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants