Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KALIGN - fix bug in error catching: remove new lines #6681

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

luisas
Copy link
Contributor

@luisas luisas commented Sep 20, 2024

Removes characters in echo statement that break msa pipeline

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • [ x] Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@luisas luisas changed the title remove new lines KALIGN - fix bug in error catching: remove new lines Sep 20, 2024
Copy link
Contributor

@alessiovignoli alessiovignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luisas luisas added this pull request to the merge queue Sep 20, 2024
Merged via the queue into nf-core:master with commit cadb9bb Sep 20, 2024
12 checks passed
@luisas luisas deleted the fix_kalign branch September 20, 2024 16:31
herpov pushed a commit to herpov/modules that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants