-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new module: jvarkit vcf2table #6631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we check the contents of the output file in some way, rather than just existence?
Another test to check the other output format and the regions or pedigree would be nice.
Should there also be something in the meta that says which tool gets which args.
Co-authored-by: Simon Pearce <[email protected]>
@SPPearce back to you. I added a test to check the content of the output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused by the regions command.
Would be nice to test the bed file, but otherwise fine
This is a PR for jvarkit/vcf2table https://jvarkit.readthedocs.io/en/latest/VcfToTable/
PR checklist
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda