Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update modules #38

Merged
merged 2 commits into from
Nov 11, 2024
Merged

update modules #38

merged 2 commits into from
Nov 11, 2024

Conversation

ramprasadn
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/createpanelrefs branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ramprasadn ramprasadn requested a review from maxulysse November 4, 2024 18:08
@ramprasadn ramprasadn linked an issue Nov 5, 2024 that may be closed by this pull request
GermlineCNVCaller resource consumption #32
Closed
maxulysse
maxulysse reviewed Nov 11, 2024
View reviewed changes
modules/nf-core/picard/createsequencedictionary/main.nf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a side question, why do we have picard for this and not gatk4?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! Doesn't matter which one we use, but it makes sense to use gatk here so we are not downloading additional containers. I will change it in another PR.

@maxulysse maxulysse merged commit 608a1ec into dev Nov 11, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GermlineCNVCaller resource consumption
2 participants
@ramprasadn @maxulysse