upstream: Forward Content-Type from upstream if we don't already have one #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorlin
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
-
/charon/getDataset?prefix=/groups/blab/sars-like-covshowsContent-Type: application/json; charset=utf-8on preview app (it doesn't on next.nextstrain.org)
… one For example, our RESTful endpoints perform content negotiation and use the result to determine Content-Type (and also what to Accept in the request to upstream), but our Charon endpoints do not set Content-Type at all. Set it based on the upstream response in that situation. I noticed this bug (while investigating another issue¹) because the automatic compression middleware wasn't applying to the /charon/getDataset endpoint due to the lack of Content-Type. ¹ <#832>
tsibley
force-pushed
the
trs/charon-content-type
branch
from
6ebc34d to
7abc6a3
Compare
jameshadfield
approved these changes
Apr 23, 2024
| /* Forward Content-Type if our response doesn't already have a preferred | ||
| * type set (e.g. from prior content negotiation). | ||
| */ | ||
| ...(!res.get("Content-Type") ? ["Content-Type"] : []), |
There was a problem hiding this comment.
The upstream content-type is 'application/json' however we are converting this to 'application/json; charset=utf-8'. In practice, I don't think clients care about charsets for JSON, but my understanding is that it shouldn't be there (see page 11 of rfc8259).
This is automagically added by express so I'm guessing it's something we will live with:
res.set({'Content-Type': 'application/json'})
console.log(res.get("Content-Type")) // application/json; charset=utf-8but I want to point this out here as our code to copy upstream headers over to the response will not just copy them but modify them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, our RESTful endpoints perform content negotiation and use the result to determine Content-Type (and also what to Accept in the request to upstream), but our Charon endpoints do not set Content-Type at all. Set it based on the upstream response in that situation.
I noticed this bug (while investigating another issue¹) because the automatic compression middleware wasn't applying to the /charon/getDataset endpoint due to the lack of Content-Type.
¹ #832
Checklist