🚧 Address react-hooks/exhaustive-deps violations

nextstrain · Jan 10, 2024 · e17c5dc · e17c5dc
1 parent 80ff382
commit e17c5dc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/static-site/.eslintrc.yaml b/static-site/.eslintrc.yaml
@@ -14,7 +14,6 @@ ignorePatterns:
 
 rules:
   react/prop-types: off
-  react-hooks/exhaustive-deps: off
 
 parserOptions:
   sourceType: module

diff --git a/static-site/src/components/Groups/edit-logo-form.jsx b/static-site/src/components/Groups/edit-logo-form.jsx
@@ -19,6 +19,12 @@ const EditLogoForm = ({ groupName, createErrorMessage, clearErrorMessage }) => {
     let cleanUp = false;
     setCurrentLogo();
     return () => cleanUp = true;
+
+  // FIXME: Figure out what to do with getGroupLogo. If it's added to the
+  // dependency list, this will get run on every render. It also can't be
+  // trivially moved outside of the component because it needs
+  // createErrorMessage and clearErrorMessage.
+  // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
 
   const getGroupLogo = async () => {