-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GenoFLU dependencies #243
Conversation
Add dependencies for GenoFLU to run in avian-flu: - ncbi-blast+ - openpyxl (for pandas.read_excel) Resolves <#242>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I haven't tested, but I can if it'd be helpful.
Thanks! I left the example command in nextstrain/avian-flu#127 (comment). |
@@ -326,6 +330,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \ | |||
less \ | |||
libgomp1 \ | |||
libsqlite3-0 \ | |||
ncbi-blast+ \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, just caught up on conversation in #127.
Worth noting this is installing https://packages.debian.org/bookworm/ncbi-blast+ which is v2.12.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this via the nextstrain/base:branch-genoflu-deps
image and all works. As a bonus it's faster than the homebrew MacOS blast!
LGTM
Re: whether this significantly increases the image size:
|
Pasting here the error you get if you try to run GenoFLU (which needs the blast tools added in this PR) with an older docker image:
|
Description of proposed changes
Add dependencies for GenoFLU to run in avian-flu:
Related issue(s)
Resolves #242
Checklist