Latest alignment to pathogen-repo-guide in 2024 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the `ingest` directory to match the latest version of the: https://github.com/nextstrain/pathogen-repo-guide/tree/b4001735fa55448f1426ff90cca93c667ca121ce/ingest
Since auspice automatically detects "authors" and we prefer the abbreviated authors list displayed, change "abbr_authors" to "authors" and "authors" to "full_authors". This matches the pathogen-repo-guide
To match the pathogen repo guide, change: * `genbank_accession` to `accession` * `genbank_accession_rev` to `accession_version` There should be a subsequent change in the phylogenetic workflow
To be more consistent with the pathogen-repo-guide and the ingest workflow
Use the combination of `accession` and `url` fields in the phylogenetic build. This change follows a similar change to the ingest workflow.
|
Ended up fixing the frequencies plot in #88 so these commits will be part of that PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Proposed Changes
While working on this repository to add the frequency panel, I took the opportunity to update the workflow to align with the latest version of the Pathogen Repo Guide.
The following commits were extracted from the larger frequency PR (#88) and are included here:
Changes to Conform to the Pathogen Repo Guide
Ingest Workflow:
authorstofull_authorsandabbr_authorstoauthors.genbank_accessiontoaccessionandgenbank_accession_revtoaccession_version.urlcolumn.release_datetodate_releasedandupdate_datetodate_updated.is_lab_hostcolumn.Phylogenetic Workflow:
*/configdirectories to*/defaults.is_lab_hostfrom downstream analysis.Related Issues
configtodefaults#77.Checklist