-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest alignment to Pathogen repo guide and add frequency panel #88
base: main
Are you sure you want to change the base?
Conversation
This commit updates the `ingest` directory to match the latest version of the: https://github.com/nextstrain/pathogen-repo-guide/tree/b4001735fa55448f1426ff90cca93c667ca121ce/ingest
Since auspice automatically detects "authors" and we prefer the abbreviated authors list displayed, change "abbr_authors" to "authors" and "authors" to "full_authors". This matches the pathogen-repo-guide
To match the pathogen repo guide, change: * `genbank_accession` to `accession` * `genbank_accession_rev` to `accession_version` There should be a subsequent change in the phylogenetic workflow
To be more consistent with the pathogen-repo-guide and the ingest workflow
Use the combination of `accession` and `url` fields in the phylogenetic build. This change follows a similar change to the ingest workflow.
073bcf2
to
a56685a
Compare
98d7a19
to
65520e5
Compare
Something is off in the frequency calculations. Here's a view from https://nextstrain.org/staging/dengue/trials/2024bfreq/dengue/all/genome?d=tree,frequencies&f_region=South%20America that just filters to South American sequences. I can mouse-over and clearly see a large number of samples from the last five years. However, none of these samples are showing up in the frequencies panel. You can see a similar issue without even filtering. It looks there's a single sample that's contributing to the KDE frequencies post 2020. |
Thank you! I was also expecting frequencies to sum up to 100%. The code changes to add frequencies panel are here, in case someone sees what's wrong faster than I can: I'm not entirely certain what is causing the empty regions:
I was mainly following frequency parameters for yellow-fever and measles but feel like I'm missing a nuance somewhere. |
Description of proposed changes
Since I was already in this repository to add the frequency panel, I decided to initiate an update to the workflow to align it with the latest version of the Pathogen Repo Guide.
Draft Frequencies Plot
Added frequencies plots from Actions run: https://github.com/nextstrain/dengue/actions/runs/12433607449
full genome frequencies:
E gene frequencies:
Feedback welcome
Related issue(s)
config
todefaults
#77Checklist