Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions] expand NCBI builds to cattle-flu & d1.1 #137

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

jameshadfield
Copy link
Member

Previously the only NCBI build was the 'h5n1-cattle-outbreak.yaml'.

Note that future work will hopefully combine these two (sets of) builds into a single config YAML, however we'll still want to incorporate the ability to toggle between the different targets in the action.

Needs testing

@jameshadfield
Copy link
Member Author

jameshadfield commented Feb 24, 2025

Testing:

  • Manual run of the "Phylogenetic NCBI" workflow for D1.1 successfully completed
  • Manual run of the "Phylogenetic NCBI" workflow for cattle-outbreak successfully completed, although note discussion points in this PR.
    • I ran this again to verify the sumary-step fixes and then cancelled the workflow once the summary had been generated
  • Ingest to phylogenetic - do we need to test this before merging, or is a review enough?

Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems fine to merge after the open discussions are resolved.

Previously the only NCBI build was the 'h5n1-cattle-outbreak.yaml'.

Note that future work will hopefully combine these two (sets of) builds
into a single config YAML, however we'll still want to incorporate the
ability to toggle between the different targets in the action.
@jameshadfield jameshadfield merged commit b38a042 into master Feb 24, 2025
10 of 15 checks passed
@jameshadfield jameshadfield deleted the james/automate-d1.1 branch February 24, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants