Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NCBI SRA/Andersen ingest #130

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Fix NCBI SRA/Andersen ingest #130

merged 3 commits into from
Feb 18, 2025

Conversation

joverlee521
Copy link
Contributor

@joverlee521 joverlee521 commented Feb 18, 2025

Description of proposed changes

  • Handle new cases of date formats in NCBI SRA metadata
  • Use existing strain name from NCBI SRA metadata if it's available.

Related issue(s)

Resolves #129

Checklist

New data now include collection dates that are the string
"missing" or date ranges (e.g. "2022-04-22/2022-04-24").
Ensure that the returned date is a valid date that can be used to
construct the strain name.

Resolves <#129>
Noticed in debugging that certain records already have the strain
name in the `isolate` field in the raw data. Use the existing strain
name if it's available, otherwise fallback to constructing a strain
name from the metadata.
@joverlee521
Copy link
Contributor Author

Diffed trial metadata and prod metadata: no changes to existing data and only added 2033 new records from SRA.
The new records have a lot of new host values, so will go through those and update the host map in this PR as well.

Update host map with latest SRA data hosts.
@joverlee521 joverlee521 merged commit 255a67d into master Feb 18, 2025
6 checks passed
@joverlee521 joverlee521 deleted the fix-andersen-ingest branch February 18, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated Ingest to phylogenetic failures
1 participant