Stricter types #1914
Merged
Stricter types #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From rule doc page¹:
It's generally better to structure program logic so that TypeScript
understands when values may be nullable.
Also added a comment to eventually move to use
plugin:@typescript-eslint/strict which includes this rule.
¹ <https://typescript-eslint.io/rules/no-non-null-assertion/>
This should not be used unless there is no other way for the TypeScript compiler to infer the type properly. In such cases, a comment with per-line exception should be used. I will address existing violations in subsequent commits.
The types can already be inferred with existing usage.
nextstrain-bot
temporarily deployed
to
auspice-victorlin-stric-xn8yld
|
Merging pre-review since nextstrain/nextstrain.org#1077 was already approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors nextstrain/nextstrain.org#1077
Checklist