Require strand in calculateStackPosition

The function is only used in two places, both of which specify a valid strand value.
nextstrain · Jan 6, 2025 · cad5eb6 · cad5eb6
1 parent 170c6f5
commit cad5eb6
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/util/entropyCreateStateFromJsons.ts b/src/util/entropyCreateStateFromJsons.ts
@@ -349,13 +349,11 @@ function _frame(
  */
 function calculateStackPosition(
   genes: Gene[],
-  strand: Strand | null = null,
+  strand: Strand,
 ): number {
   /* List of CDSs, sorted by their earliest occurrence in the genome (for any segment) */
   let cdss = genes.reduce((acc: CDS[], gene) => [...acc, ...gene.cds], []);
-  if (strand) {
-    cdss = cdss.filter((cds) => cds.strand===strand);
-  }
+  cdss = cdss.filter((cds) => cds.strand===strand);
   cdss.sort((a, b) =>
     Math.min(...a.segments.map((s) => s.rangeGenome[0])) < Math.min(...b.segments.map((s) => s.rangeGenome[0])) ?
       -1 : 1