Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip CI for PRs on Markdown changes #1721

Closed
wants to merge 2 commits into from
Closed

Conversation

huddlej
Copy link
Contributor

@huddlej huddlej commented Jan 14, 2025

Description of proposed changes

Skips the CI workflow when we change the README or change log in a PR. Changes to these files should not produce a different outcome in CI, so we don't need to waste compute rerunning CI for these files. CI will still run for these changes when pushed to master, since the change log gets built as part of our documentation.

Related issue(s)

Checklist

  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

Skips the CI workflow when we change the README or change log in a PR.
Changes to these files should not produce a different outcome in CI, so
we don't need to waste compute rerunning CI for these files. CI will
still run for these changes when pushed to `master`, since the change
log gets built as part of our documentation.
To be dropped after testing.
@huddlej
Copy link
Contributor Author

huddlej commented Jan 14, 2025

It looks like this change won't actually be helpful until actions/runner#2324 is fixed. The main use case for this change is to avoid running CI on a PR when we've updated the change log after making other changes to the code. It seems that CI will always run for every commit if any commit exists in the PR that changes a file other than the two ignored here.

@huddlej huddlej closed this Jan 14, 2025
@victorlin victorlin deleted the ignore-md-changes branch January 14, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants