-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(setupchecks): add row format setup check for MySQL databases #48547
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,70 @@ | ||||||
<?php | ||||||
|
||||||
declare(strict_types=1); | ||||||
|
||||||
/** | ||||||
* SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors | ||||||
* SPDX-License-Identifier: AGPL-3.0-or-later | ||||||
*/ | ||||||
namespace OCA\Settings\SetupChecks; | ||||||
|
||||||
use Doctrine\DBAL\Platforms\MySQLPlatform; | ||||||
use OC\DB\Connection; | ||||||
use OCP\IConfig; | ||||||
use OCP\IL10N; | ||||||
use OCP\IURLGenerator; | ||||||
use OCP\SetupCheck\ISetupCheck; | ||||||
use OCP\SetupCheck\SetupResult; | ||||||
|
||||||
class MysqlRowFormat implements ISetupCheck { | ||||||
public function __construct( | ||||||
private IL10N $l10n, | ||||||
private IConfig $config, | ||||||
private Connection $connection, | ||||||
private IURLGenerator $urlGenerator, | ||||||
) { | ||||||
} | ||||||
|
||||||
public function getName(): string { | ||||||
return $this->l10n->t('MySQL row format'); | ||||||
} | ||||||
|
||||||
public function getCategory(): string { | ||||||
return 'database'; | ||||||
} | ||||||
|
||||||
public function run(): SetupResult { | ||||||
if (!$this->connection->getDatabasePlatform() instanceof MySQLPlatform) { | ||||||
return SetupResult::success($this->l10n->t('You are not using MySQL')); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you think it makes sense to introduce something like |
||||||
} | ||||||
|
||||||
$compressedRowTables = $this->getRowCompressedTables(); | ||||||
if (empty($compressedRowTables)) { | ||||||
return SetupResult::success($this->l10n->t('None of your table use ROW_FORMAT=Compressed')); | ||||||
} | ||||||
|
||||||
return SetupResult::warning( | ||||||
$this->l10n->t( | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: consider L10n::n for "table" vs "tables" |
||||||
'Some tables are using ROW_FORMAT=Compressed. This format is known to hurt performances. Please fix the following tables: %s', | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we say, please change the row format for the following tables to dynamic? |
||||||
implode(', ', $compressedRowTables), | ||||||
), | ||||||
'https://dev.mysql.com/doc/refman/en/innodb-row-format.html', | ||||||
); | ||||||
} | ||||||
|
||||||
/** | ||||||
* @return string[] | ||||||
*/ | ||||||
private function getRowCompressedTables(): array { | ||||||
$sql = 'SELECT table_name | ||||||
FROM information_schema.tables | ||||||
WHERE table_schema = ? | ||||||
AND table_name LIKE "*PREFIX*%" | ||||||
AND row_format = "Compressed";'; | ||||||
Comment on lines
+59
to
+63
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you not run this with our query builder? |
||||||
|
||||||
return $this->connection->executeQuery( | ||||||
$sql, | ||||||
[$this->config->getSystemValueString('dbname')], | ||||||
)->fetchFirstColumn(); | ||||||
} | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.