-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(setupchecks): add row format setup check for MySQL databases #48547
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Benjamin Gaussorgues <[email protected]>
declare(strict_types=1); | ||
|
||
/** | ||
* SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors | |
* SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors |
|
||
public function run(): SetupResult { | ||
if (!$this->connection->getDatabasePlatform() instanceof MySQLPlatform) { | ||
return SetupResult::success($this->l10n->t('You are not using MySQL')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it makes sense to introduce something like SetupResult::skipped
and then filter out the setup checks with severity = skipped by default? If you think so, I would log a feature request.
|
||
return SetupResult::warning( | ||
$this->l10n->t( | ||
'Some tables are using ROW_FORMAT=Compressed. This format is known to hurt performances. Please fix the following tables: %s', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Some tables are using ROW_FORMAT=Compressed. This format is known to hurt performances. Please fix the following tables: %s', | |
'Some tables are using ROW_FORMAT=Compressed. This format is known to affect performances. Please fix the following tables: %s', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we say, please change the row format for the following tables to dynamic?
I think "redundant" and "compact" are no real options because they don't support large index key prefix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
} | ||
|
||
return SetupResult::warning( | ||
$this->l10n->t( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: consider L10n::n for "table" vs "tables"
$sql = 'SELECT table_name | ||
FROM information_schema.tables | ||
WHERE table_schema = ? | ||
AND table_name LIKE "*PREFIX*%" | ||
AND row_format = "Compressed";'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you not run this with our query builder?
Summary
Add a setup check to warn about tables using ROW_FORMAT=Compressed
MySQL specific
Checklist