feat(setupchecks): add row format setup check for MySQL databases #48547
+74
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Gaussorgues <[email protected]>
Altahrim
requested review from
yemkareems,
provokateurin and
sorbaugh
and removed request for
a team
provokateurin
approved these changes
Oct 3, 2024
kesselb
approved these changes
Oct 3, 2024
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors |
There was a problem hiding this comment.
Suggested change
| * SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors | |
| * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors |
|
|
||
| public function run(): SetupResult { | ||
| if (!$this->connection->getDatabasePlatform() instanceof MySQLPlatform) { | ||
| return SetupResult::success($this->l10n->t('You are not using MySQL')); |
There was a problem hiding this comment.
Do you think it makes sense to introduce something like SetupResult::skipped and then filter out the setup checks with severity = skipped by default? If you think so, I would log a feature request.
|
|
||
| return SetupResult::warning( | ||
| $this->l10n->t( | ||
| 'Some tables are using ROW_FORMAT=Compressed. This format is known to hurt performances. Please fix the following tables: %s', |
There was a problem hiding this comment.
Suggested change
| 'Some tables are using ROW_FORMAT=Compressed. This format is known to hurt performances. Please fix the following tables: %s', | |
| 'Some tables are using ROW_FORMAT=Compressed. This format is known to affect performances. Please fix the following tables: %s', |
There was a problem hiding this comment.
Could we say, please change the row format for the following tables to dynamic?
I think "redundant" and "compact" are no real options because they don't support large index key prefix.
| } | ||
|
|
||
| return SetupResult::warning( | ||
| $this->l10n->t( |
There was a problem hiding this comment.
nit: consider L10n::n for "table" vs "tables"
Comment on lines
+59
to
+63
| $sql = 'SELECT table_name | ||
| FROM information_schema.tables | ||
| WHERE table_schema = ? | ||
| AND table_name LIKE "*PREFIX*%" | ||
| AND row_format = "Compressed";'; |
There was a problem hiding this comment.
can you not run this with our query builder?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a setup check to warn about tables using ROW_FORMAT=Compressed
MySQL specific
Checklist