-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcCounterBubble): show original count in title when shortened #6395
Merged
+30
−8
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
fix(NcCounterBubble): show original count in title when shortened
Signed-off-by: Grigorii K. Shartsev <[email protected]>
commit 78cd95f274f635ebd1ae4891251cabb4c96f31af
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unchanged files with check annotations Beta
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isRTL: isRTL(), | ||
} | ||
}, | ||
mixins: [ActionTextMixin], | ||
inject: { | ||
isInSemanticMenu: { | ||
from: 'NcActions:isSemanticMenu', | ||
default: false, | ||
}, | ||
}, | ||
props: { | ||
/** | ||
* @deprecated To be removed in @nextcloud/vue 9. Migration guide: remove ariaHidden prop from NcAction* components. | ||
* @todo Add a check in @nextcloud/vue 9 that this prop is not provided, |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return this.$refs.menu.querySelector('li.active') | ||
}, | ||
/** | ||
* @return {NodeListOf<HTMLElement>} | ||
*/ | ||
getFocusableMenuItemElements() { | ||
return this.$refs.menu.querySelectorAll(focusableSelector) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<template> | ||
<span ref="main" | ||
:title="tooltip" | ||
v-click-outside="closeMenu" | ||
:class="{ | ||
'avatardiv--unknown': userDoesNotExist, | ||
'avatardiv--with-menu': hasMenu, |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
listeners() { | ||
return { | ||
...this.$listeners, | ||
/** | ||
Check warning on line 303 in src/components/NcDateTimePickerNative/NcDateTimePickerNative.vue
|
||
* Handle the input event | ||
* | ||
* @param {InputEvent} $event input event payload |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer this but this is also fine for me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer
.toString()
as a safer method. If something went wrong andcount
is invalid, e.g.null
orundefined
,.toString()
fails explicitly whileString
constructor successfully created string'undefined'
which goes to UI or further to computations.