fix(NcCounterBubble): show original count in title when shortened #6395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
changed the title
susnux
approved these changes
Jan 18, 2025
| @@ -243,7 +243,7 @@ export default { | |||
| methods: { | |||
| humanizeCount(count) { | |||
| if (this.raw) { | |||
| return count | |||
| return count.toString() | |||
There was a problem hiding this comment.
I prefer this but this is also fine for me :)
Suggested change
| return count.toString() | |
| return String(count) |
There was a problem hiding this comment.
I prefer .toString() as a safer method. If something went wrong and count is invalid, e.g. null or undefined, .toString() fails explicitly while String constructor successfully created string 'undefined' which goes to UI or further to computations.
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
fix/NcCounterBubble--title
branch
from
193acde to
78cd95f
Compare
Fixed |
|
/backport to next |
Antreesy
approved these changes
Jan 20, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade