Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Node 20 support #170

Merged
merged 1 commit into from
Nov 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,19 @@ jobs:
name: Publish layer
command: make publish-nodejs18x-ci

publish-nodejs20x:
docker:
- image: cimg/node:20.4.0
steps:
- checkout
- setup_remote_docker
- run:
name: Node 20 unit tests
command: cd nodejs && npm install && npm run test
- run:
name: Publish layer
command: make publish-nodejs20x-ci

publish-python37:
docker:
- image: cimg/python:3.7
Expand Down Expand Up @@ -167,6 +180,16 @@ workflows:
- codecov/upload:
file: ./nodejs/coverage/unit/lcov.info
flags: nodejs-18-unit
- publish-nodejs20x:
filters:
branches:
ignore: /.*/
tags:
only: /v[0-9]+(\.[0-9]+)*_nodejs/
post-steps:
- codecov/upload:
file: ./nodejs/coverage/unit/lcov.info
flags: nodejs-20-unit
- publish-python37:
filters:
branches:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:

strategy:
matrix:
node-version: [16.x, 18.x]
node-version: [16.x, 18.x, 20.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand All @@ -61,7 +61,7 @@ jobs:

strategy:
matrix:
node-version: [16.x, 18.x]
node-version: [16.x, 18.x, 20.x]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 6 additions & 0 deletions libBuild.sh
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ function layer_name_str() {
"nodejs18.x")
rt_part="NodeJS18X"
;;
"nodejs20.x")
rt_part="NodeJS20X"
;;
esac

case $2 in
Expand Down Expand Up @@ -164,6 +167,9 @@ function s3_prefix() {
"nodejs18.x")
name="nr-nodejs18.x"
;;
"nodejs20.x")
name="nr-nodejs20.x"
;;
esac

echo $name
Expand Down
Loading
Loading