feat: Added Node 20 support #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
reviewed
Aug 29, 2023
|
@bizob2828 I do have to rebase, though I didn't forget: this branch was opened before I removed Node 14 support today. |
mrickard
force-pushed
the
NR-141663/add-node-20
branch
from
fc02962 to
432da66
Compare
|
Noting that I need to add check runs for Node 20. EDIT: added, but currently failing integration for Node 20 in CI (not locally). |
|
CI for Node 20 is currently blocked until serverless-offline releases its just-merged support for Node 20: https://github.com/dherault/serverless-offline |
mrickard
force-pushed
the
NR-141663/add-node-20
branch
from
c508ef4 to
13387bc
Compare
|
@bizob2828 I've rebased this against the wrapper-update PR, and added the new serverless-offline with Node 20 support, so now we're passing. |
bizob2828
reviewed
Nov 28, 2023
Signed-off-by: mrickard <[email protected]>
mrickard
force-pushed
the
NR-141663/add-node-20
branch
from
c820a87 to
5592771
Compare
bizob2828
approved these changes
Nov 28, 2023
mrickard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to anticipate Node 20 being introduced as a supported Lambda runtime.
Closes #169
Closes NR-141663