Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress wp-pointer using css #306

Merged
merged 4 commits into from
May 20, 2024
Merged

Suppress wp-pointer using css #306

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2603212
Suppress wp-pointer using css
mamatharao05 May 13, 2024
ef38b9a
lock file update
mamatharao05 May 15, 2024
dffd420
Suppress WP Form notice for crazy domains too
mamatharao05 May 16, 2024
ba35361
Merge branch 'trunk' of https://github.com/newfold-labs/wp-module-eco…
mamatharao05 May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions includes/ECommerce.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ public function __construct( Container $container ) {
add_filter( 'manage_edit-page_sortable_columns', array( $this, 'sortable_columns' ) );
add_action( 'wp_login', array( $this, 'show_store_setup' ) );
add_action( 'auth_cookie_expired', array( $this, 'show_store_setup' ) );

add_action('admin_enqueue_scripts', array( $this, 'set_wpnav_collapse_setting'));
add_action('admin_head', array( $this, 'hide_wp_pointer_with_css' ) );
add_action('admin_enqueue_scripts', array( $this, 'set_wpnav_collapse_setting'));

if ( ( $container->plugin()->id === 'bluehost' && ( $canAccessGlobalCTB || $hasYithExtended ) ) || ( $container->plugin()->id === 'hostgator' && $hasYithExtended ) ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Yoda here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't made any changes to the existing code.

add_filter( 'admin_menu', array( $this, 'custom_add_promotion_menu_item' ) );
Expand Down Expand Up @@ -675,4 +675,19 @@ function check_url_match( $brand_name, $site_url ) {
update_option( 'showMigrationSteps', false );
}
}

/**
* Suppress WP-Form Notice using css
*
* @return void
*/

public function hide_wp_pointer_with_css() {
$brand = $this->container->plugin()->id;
if ( 'bluehost' === $brand || 'hostgator' === $brand ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using Yoda in Ecommerce as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aratidgr8 This is the newfold standard. So I followed here too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need this for crazy-domains

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Applicable for Bluehost, Hostgator and crazy domains.

echo '<style>
.wp-pointer { display: none !important; }
</style>';
}
}
}
Loading