Suppress wp-pointer using css #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aratidgr8
reviewed
May 14, 2024
includes/ECommerce.php
Outdated
|
|
||
| public function hide_wp_pointer_with_css() { | ||
| $brand = $this->container->plugin()->id; | ||
| if ( 'bluehost' === $brand || 'hostgator' === $brand ) { |
There was a problem hiding this comment.
Are we using Yoda in Ecommerce as well?
There was a problem hiding this comment.
@aratidgr8 This is the newfold standard. So I followed here too.
includes/ECommerce.php
Outdated
|
|
||
| public function hide_wp_pointer_with_css() { | ||
| $brand = $this->container->plugin()->id; | ||
| if ( 'bluehost' === $brand || 'hostgator' === $brand ) { |
There was a problem hiding this comment.
Don't we need this for crazy-domains
There was a problem hiding this comment.
Updated. Applicable for Bluehost, Hostgator and crazy domains.
aratidgr8
reviewed
May 16, 2024
|
|
||
| add_action('admin_enqueue_scripts', array( $this, 'set_wpnav_collapse_setting')); | ||
| add_action('admin_head', array( $this, 'hide_wp_pointer_with_css' ) ); | ||
| add_action('admin_enqueue_scripts', array( $this, 'set_wpnav_collapse_setting')); | ||
|
|
||
| if ( ( $container->plugin()->id === 'bluehost' && ( $canAccessGlobalCTB || $hasYithExtended ) ) || ( $container->plugin()->id === 'hostgator' && $hasYithExtended ) ) { |
There was a problem hiding this comment.
I haven't made any changes to the existing code.
…mmerce into PRESS0-1248-Supress-Wpform-Notice
aratidgr8
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added hook to suppress WP-Form notice using CSS for Bluehost, Hostgator and Crazy domains.
Ticket: https://jira.newfold.com/browse/PRESS0-1248
Before
After
