Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update lock file step #227

Closed
wants to merge 5 commits into from
Closed

Fix update lock file step #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
07d1169
Fix update lock file step
sangeetha-nayak Feb 23, 2024
2cf7906
Remove validate for plugin
sangeetha-nayak Feb 23, 2024
a64921d
added -W option
sangeetha-nayak Feb 23, 2024
467945b
Reverted back changes
sangeetha-nayak Feb 23, 2024
d3653bc
revert back composer change
sangeetha-nayak Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/brand-plugin-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
branches:
- main
- trunk

workflow_dispatch:

concurrency:
Expand Down
8 changes: 1 addition & 7 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,7 @@ jobs:
- name: Modify composer.json
run: |
node ./vendor/newfold-labs/wp-module-ecommerce/scripts/update-plugin-composer.mjs ${PWD}/composer.json ${PWD}/vendor

- name: Update lockfile
Copy link
Contributor

@aratidgr8 aratidgr8 Feb 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sangeetha-nayak Why have we removed these steps?

run: composer update

- name: Validate composer.json and composer.lock
run: composer validate


- name: Install PHP Dependencies
run: composer install --no-progress --no-dev --optimize-autoloader --prefer-dist

Expand Down
Loading