Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update lock file step #227

Closed
wants to merge 5 commits into from
Closed

Fix update lock file step #227

wants to merge 5 commits into from

Conversation

sangeetha-nayak
Copy link
Contributor

No description provided.

@@ -77,12 +77,6 @@ jobs:
run: |
node ./vendor/newfold-labs/wp-module-ecommerce/scripts/update-plugin-composer.mjs ${PWD}/composer.json ${PWD}/vendor

- name: Update lockfile
Copy link
Contributor

@aratidgr8 aratidgr8 Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sangeetha-nayak Why have we removed these steps?

@sangeetha-nayak
Copy link
Contributor Author

ecommerce requires onboarding-data 1.1 ahead of release from BH which is currently at 0.1. This mismatch is causing composer update to fail which is expected. This should get automatically resolved once goes into BH repo. Closing this PR.

@sangeetha-nayak sangeetha-nayak deleted the fix_workflow branch February 23, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants