Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create a new tag #41

Open
ilovezfs opened this issue May 3, 2016 · 4 comments
Open

Please create a new tag #41

ilovezfs opened this issue May 3, 2016 · 4 comments

Comments

@ilovezfs
Copy link

ilovezfs commented May 3, 2016

Right now Homebrew is stuck on 0.9.8 because that's the only available tarball download:
https://github.com/Homebrew/homebrew-core/blob/master/Formula/henplus.rb#L4

Do you mind tagging a new version so the formula can be brought up to date with the latest bits?

Thanks so much.

@neurolabs
Copy link
Owner

Is a tag enough? Or do I need to bundle a tgz?

And what name should a tag have in order to play nice with homebrew? I don't want to use a version number, because then I would feel obliged to officially do a release.

@ilovezfs
Copy link
Author

ilovezfs commented May 3, 2016

The existence of the tag automatically makes tarballs available. The biggest reason for needing them is that Homebrew formulae have the sha256 in the file to ensure integrity. The second biggest reason is so that we have an explicit signal from upstream that it can be released as our stable spec for the formula, as opposed to assuming any old random commit at HEAD is good to go.

The only real restriction with version number is that it be strictly monotonically increasing. So since the last tag was 0.9.8, the next one needs to be >= 0.9.8.1 or >= 0.9.9

@neurolabs
Copy link
Owner

would it be ok to do this in a couple of days after merging #40 and the followup pull request (still needs some work and review)?

@ilovezfs
Copy link
Author

ilovezfs commented May 4, 2016

@neurolabs Yes, that's fine, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants