henplus: use :java requirement #806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilovezfs
force-pushed
the
henplus-trigger-ci
branch
from
c060ca8
to
421568c
Compare
|
This won't test on CI because one of the dependencies wants Java 1.6, somehow. Personally given the need for an ancient Java I'd just been tempted to kill this and |
|
@DomT4 I've fixed the libreadline-java issue and reported it upstream: #837 In addition, henplus upstream has agreed to create a new tag: neurolabs/henplus#41 So I don't think either need be removed. |
|
Alright, as long as you're working on it. Anything using Java 1.6 these days frankly seems unsupported by upstream. |
ilovezfs
force-pushed
the
henplus-trigger-ci
branch
from
421568c
to
5920c12
Compare
ilovezfs
force-pushed
the
henplus-trigger-ci
branch
from
5920c12
to
72c9f83
Compare
|
@DomT4 🚢? |
|
Seems reasonable 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.