Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgur-album-downloader (new formula) #936

Closed
wants to merge 5 commits into from
Closed

imgur-album-downloader (new formula) #936

wants to merge 5 commits into from

Conversation

sgsunder
Copy link

@sgsunder sgsunder commented May 7, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

Adds formula for imgur album downloader

@UniqMartin UniqMartin changed the title Added Imgur Album Downloader Formula imgur-album-downloader (new formula) May 7, 2016
@UniqMartin UniqMartin added the new formula PR adds a new formula to Homebrew/homebrew-core label May 7, 2016
@ilovezfs
Copy link
Contributor

ilovezfs commented May 7, 2016

@sgsunder Something's off with the test's syntax:

Testing imgur-album-downloader
==> Using the sandbox
/usr/bin/sandbox-exec -f /tmp/homebrew20160507-69170-aw5osl.sb /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/bin/ruby -W0 -I /usr/local/Library/Homebrew -- /usr/local/Library/Homebrew/test.rb /usr/local/Library/Taps/homebrew/homebrew-core/Formula/imgur-album-downloader.rb --verbose
==> /usr/local/Cellar/imgur-album-downloader/1/bin/imgur-album-downloader --help
Error: URL must be a valid Imgur Album

How to use
=============

Quickly and easily download an album from Imgur.

Format:
    $ python imguralbum.py [album URL] [destination folder]

Example:
    $ python imguralbum.py http://imgur.com/a/uOOju#6 /Users/alex/images

If you omit the dest folder name, the utility will create one with the same name
as the album
(for example for http://imgur.com/a/uOOju it'll create uOOju/ in the cwd)

Error: imgur-album-downloader: failed
Failed executing: /usr/local/Cellar/imgur-album-downloader/1/bin/imgur-album-downloader --help

Fixed test code to exit cleanly. Also removed unneeded comments.
@sgsunder
Copy link
Author

sgsunder commented May 7, 2016

Fixed the test. Wasn't supposed to use a '--help' flag.

@sgsunder sgsunder closed this May 7, 2016
@sgsunder sgsunder reopened this May 7, 2016
class ImgurAlbumDownloader < Formula
desc "Command Line Utility to Download Imgur Albums"
homepage "https://github.com/sgsunder/imgur-album-downloader"
url "https://github.com/alexgisby/imgur-album-downloader.git", :revision => "dbaee1e342c1b46c022fccd26c294e251ac04015"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a tagged release here.

Made some of the suggested changes
@sgsunder
Copy link
Author

sgsunder commented May 7, 2016

I'm not sure what you mean by "tagged release." Is it not acceptable to fix to a specific commit?

@DomT4
Copy link
Member

DomT4 commented May 7, 2016

I'm afraid not. We require a stable, tagged upstream release for formulae in this repository.

@DomT4
Copy link
Member

DomT4 commented May 7, 2016

A tagged release in this context being something similar to as seen here.

@DomT4 DomT4 added the needs response Needs a response from the issue/PR author label May 8, 2016
@ilovezfs
Copy link
Contributor

ilovezfs commented May 8, 2016

@sgsunder you need to file an issue with upstream (https://github.com/alexgisby/imgur-album-downloader/issues) and ask them to create a tag.

Here are some examples of such a request:
https://github.com/scantailor/scantailor/issues/204
neurolabs/henplus#41
att/ast#3

@sgsunder
Copy link
Author

sgsunder commented May 8, 2016

Will do. I'll keep this thread posted for a response.

@ghost ghost removed the needs response Needs a response from the issue/PR author label May 8, 2016
@DomT4 DomT4 added the upstream issue An upstream issue report is needed label May 8, 2016
depends_on "python3"

def install
bin.install "imguralbum.py" => "imgur-album-downloader" # Rename Command Line Script
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove the comment.

@DomT4 DomT4 added the needs response Needs a response from the issue/PR author label May 21, 2016
@ghost ghost removed the needs response Needs a response from the issue/PR author label Jul 22, 2016
@DomT4 DomT4 added the needs response Needs a response from the issue/PR author label Jul 24, 2016
@DomT4
Copy link
Member

DomT4 commented Aug 8, 2016

It looks like there's no prospect of a stable release here from a stable repo any time soon; we've been waiting since early May & still no progress.

Will happily re-review this PR or a fresh one if a stable release is ever published, but for now I'm going to close with the presumption there's not one coming soon. Thank you nonetheless for your submission to Homebrew @sgsunder ❤️.

@DomT4 DomT4 closed this Aug 8, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs response Needs a response from the issue/PR author new formula PR adds a new formula to Homebrew/homebrew-core upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants