-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imgur-album-downloader (new formula) #936
Conversation
@sgsunder Something's off with the test's syntax:
|
Fixed test code to exit cleanly. Also removed unneeded comments.
Fixed the test. Wasn't supposed to use a '--help' flag. |
class ImgurAlbumDownloader < Formula | ||
desc "Command Line Utility to Download Imgur Albums" | ||
homepage "https://github.com/sgsunder/imgur-album-downloader" | ||
url "https://github.com/alexgisby/imgur-album-downloader.git", :revision => "dbaee1e342c1b46c022fccd26c294e251ac04015" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a tagged release here.
Made some of the suggested changes
Added test album
I'm not sure what you mean by "tagged release." Is it not acceptable to fix to a specific commit? |
I'm afraid not. We require a stable, tagged upstream release for formulae in this repository. |
A tagged release in this context being something similar to as seen here. |
@sgsunder you need to file an issue with upstream (https://github.com/alexgisby/imgur-album-downloader/issues) and ask them to create a tag. Here are some examples of such a request: |
Will do. I'll keep this thread posted for a response. |
depends_on "python3" | ||
|
||
def install | ||
bin.install "imguralbum.py" => "imgur-album-downloader" # Rename Command Line Script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove the comment.
It looks like there's no prospect of a stable release here from a stable repo any time soon; we've been waiting since early May & still no progress. Will happily re-review this PR or a fresh one if a stable release is ever published, but for now I'm going to close with the presumption there's not one coming soon. Thank you nonetheless for your submission to Homebrew @sgsunder ❤️. |
brew install <formula>
(where<formula>
is the name of the formula you're submitting)?brew audit --strict --online <formula>
(after doingbrew install <formula>
)?Adds formula for imgur album downloader