Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Rename API_QUERY_URL to NB_API_QUERY_URL #26

Merged
merged 1 commit into from
Mar 26, 2024
Merged

[REF] Rename API_QUERY_URL to NB_API_QUERY_URL #26

merged 1 commit into from
Mar 26, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Mar 22, 2024 •
edited by surchs
Loading

Changes proposed in this pull request:

  • Environment variable name updated to work with new React query tool

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@surchs surchs self-requested a review March 22, 2024 20:49
surchs
surchs approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🧑‍🍳

Thanks a lot!

@alyssadai alyssadai merged commit 615dba5 into main Mar 26, 2024
@alyssadai alyssadai deleted the rename-query-tool-env-var branch March 26, 2024 05:50
@neurobagel-bot Neurobagel Bot
Copy link

neurobagel-bot bot commented Aug 7, 2024

🚀 PR was released in v0.0.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API_QUERY_URL needs renaming to NB_API_QUERY_URL
2 participants
@alyssadai @surchs