Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mark ParseObject and related types as Sendable #174

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Jul 11, 2024

New Pull Request Checklist

Issue Description

A step towards Strict concurrency, #119 (reply in thread) is still valid, though SPI shows ParseSwift as free from data races, https://swiftpackageindex.com/netreconlab/Parse-Swift

Approach

Make as many protocols and types conform to Sendable

TODOs before merging

  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@cbaker6 cbaker6 linked an issue Jul 11, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.27%. Comparing base (55d9d22) to head (5d7ebd6).

Files Patch % Lines
...Authentication/Protocols/ParseAuthentication.swift 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   91.29%   91.27%   -0.03%     
==========================================
  Files         178      178              
  Lines       12079    12083       +4     
==========================================
+ Hits        11028    11029       +1     
- Misses       1051     1054       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbaker6 cbaker6 merged commit 10ec67c into main Jul 11, 2024
14 checks passed
@cbaker6 cbaker6 deleted the sendable branch July 11, 2024 02:02
@cbaker6 cbaker6 mentioned this pull request Jul 13, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ParseObject Sendable
1 participant