feat: Mark ParseObject and related types as Sendable (#174)

* feat: Mark ParseObject and related types as Sendable

* more Sendable

* Update CHANGELOG.md

* More Sendable

CHANGELOG.md

@@ -2,10 +2,16 @@
 # Parse-Swift Changelog
 
 ### main
-[Full Changelog](https://github.com/netreconlab/Parse-Swift/compare/5.9.3...main), [Documentation](https://swiftpackageindex.com/netreconlab/Parse-Swift/main/documentation/parseswift)
+[Full Changelog](https://github.com/netreconlab/Parse-Swift/compare/5.10.0...main), [Documentation](https://swiftpackageindex.com/netreconlab/Parse-Swift/main/documentation/parseswift)
 * _Contributing to this repo? Add info about your change here to be included in the next release_
 
 
+### 5.10.0
+[Full Changelog](https://github.com/netreconlab/Parse-Swift/compare/5.9.3...5.10.0), [Documentation](https://swiftpackageindex.com/netreconlab/Parse-Swift/5.10.0/documentation/parseswift)
+
+__New features__
+* Make many of the Parse protocols and types conform to Sendable ([#174](https://github.com/netreconlab/Parse-Swift/pull/174)), thanks to [Corey Baker](https://github.com/cbaker6).
+
 ### 5.9.3
 [Full Changelog](https://github.com/netreconlab/Parse-Swift/compare/5.9.2...5.9.3), [Documentation](https://swiftpackageindex.com/netreconlab/Parse-Swift/5.9.3/documentation/parseswift)
 

ParseSwift.xcodeproj/project.pbxproj

@@ -142,6 +142,7 @@
 		707A3BF125B0A4F0000D215C /* ParseAuthentication.swift in Sources */ = {isa = PBXBuildFile; fileRef = 707A3BF025B0A4F0000D215C /* ParseAuthentication.swift */; };
 		707A3C1125B0A8E8000D215C /* ParseAnonymous.swift in Sources */ = {isa = PBXBuildFile; fileRef = 707A3C1025B0A8E8000D215C /* ParseAnonymous.swift */; };
 		707A3C2025B14BD0000D215C /* ParseApple.swift in Sources */ = {isa = PBXBuildFile; fileRef = 707A3C1F25B14BCF000D215C /* ParseApple.swift */; };
+		707DC1C02C3F5DE900FC1DFD /* InputStream.swift in Sources */ = {isa = PBXBuildFile; fileRef = 707DC1BF2C3F5DE900FC1DFD /* InputStream.swift */; };
 		7085DD9426CBF3A70033B977 /* Documentation.docc in Sources */ = {isa = PBXBuildFile; fileRef = 7085DD9326CBF3A70033B977 /* Documentation.docc */; };
 		7085DDA326CC8A470033B977 /* ParseServer+combine.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7085DDA226CC8A470033B977 /* ParseServer+combine.swift */; };
 		7085DDB326D1EC7F0033B977 /* ParseAuthenticationCombineTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7085DDB226D1EC7F0033B977 /* ParseAuthenticationCombineTests.swift */; };
@@ -489,6 +490,7 @@
 		707A3BF025B0A4F0000D215C /* ParseAuthentication.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ParseAuthentication.swift; sourceTree = "<group>"; };
 		707A3C1025B0A8E8000D215C /* ParseAnonymous.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ParseAnonymous.swift; sourceTree = "<group>"; };
 		707A3C1F25B14BCF000D215C /* ParseApple.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ParseApple.swift; sourceTree = "<group>"; };
+		707DC1BF2C3F5DE900FC1DFD /* InputStream.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = InputStream.swift; sourceTree = "<group>"; };
 		7085DD9326CBF3A70033B977 /* Documentation.docc */ = {isa = PBXFileReference; lastKnownFileType = folder.documentationcatalog; path = Documentation.docc; sourceTree = "<group>"; };
 		7085DDA226CC8A470033B977 /* ParseServer+combine.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "ParseServer+combine.swift"; sourceTree = "<group>"; };
 		7085DDB226D1EC7F0033B977 /* ParseAuthenticationCombineTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ParseAuthenticationCombineTests.swift; sourceTree = "<group>"; };
@@ -1084,6 +1086,7 @@
 				706436A827341FD0007C6461 /* Date.swift */,
 				70C048C02880D7E500401689 /* Dictionary.swift */,
 				706436A327341F6E007C6461 /* Encodable.swift */,
+				707DC1BF2C3F5DE900FC1DFD /* InputStream.swift */,
 				9116F66E26A35D600082F6D6 /* URLCache.swift */,
 				F97B462C24D9C74400F4A88B /* URLSession.swift */,
 			);
@@ -1602,6 +1605,7 @@
 				916E207029D8C83100C21EC6 /* ParseRelationOperationable.swift in Sources */,
 				70B4E0BC2762F1D5004C9757 /* QueryConstraint.swift in Sources */,
 				70C167B427304F09009F4E30 /* Pointer+async.swift in Sources */,
+				707DC1C02C3F5DE900FC1DFD /* InputStream.swift in Sources */,
 				705025AE28456106008D6624 /* ParsePushStatusable.swift in Sources */,
 				F97B464A24D9C78B00F4A88B /* ParseOperationDelete.swift in Sources */,
 				705025CC284CE4C2008D6624 /* ParsePushPayloadable.swift in Sources */,
@@ -1918,6 +1922,7 @@
 				SDKROOT = iphoneos;
 				SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
 				SWIFT_OPTIMIZATION_LEVEL = "-Onone";
+				SWIFT_STRICT_CONCURRENCY = minimal;
 				SWIFT_VERSION = 5.0;
 				TVOS_DEPLOYMENT_TARGET = 13.0;
 				VERSIONING_SYSTEM = "apple-generic";
@@ -1982,6 +1987,7 @@
 				SDKROOT = iphoneos;
 				SWIFT_COMPILATION_MODE = wholemodule;
 				SWIFT_OPTIMIZATION_LEVEL = "-O";
+				SWIFT_STRICT_CONCURRENCY = minimal;
 				SWIFT_VERSION = 5.0;
 				TVOS_DEPLOYMENT_TARGET = 13.0;
 				VALIDATE_PRODUCT = YES;

Sources/ParseSwift/API/API+Command.swift

@@ -14,12 +14,12 @@ import FoundationNetworking
 internal extension API {
     // MARK: API.Command
     // swiftlint:disable:next type_body_length
-    struct Command<T, U>: Encodable where T: ParseEncodable {
+    struct Command<T, U>: Encodable, Sendable where T: ParseEncodable, U: Sendable {
         typealias ReturnType = U // swiftlint:disable:this nesting
         let method: API.Method
         let path: API.Endpoint
         let body: T?
-        let mapper: ((Data) async throws -> U)
+        let mapper: (@Sendable (Data) async throws -> U)
         let params: [String: String?]?
         let uploadData: Data?
         let uploadFile: URL?
@@ -36,7 +36,7 @@ internal extension API {
              parseURL: URL? = nil,
              otherURL: URL? = nil,
              stream: InputStream? = nil,
-             mapper: @escaping ((Data) async throws -> U)) {
+             mapper: @escaping (@Sendable (Data) async throws -> U)) {
             self.method = method
             self.path = path
             self.body = body
@@ -429,8 +429,9 @@ internal extension API.Command {
             let acl = try? await ParseACL.defaultACL() {
             object.ACL = acl
         }
-        let mapper = { (data) -> V in
-            try ParseCoding.jsonDecoder().decode(CreateResponse.self, from: data).apply(to: object)
+        let updatedObject = object
+        let mapper = { @Sendable (data) -> V in
+            try ParseCoding.jsonDecoder().decode(CreateResponse.self, from: data).apply(to: updatedObject)
         }
         return API.Command<V, V>(method: .POST,
                                  path: try await object.endpoint(.POST),
@@ -444,7 +445,7 @@ internal extension API.Command {
             throw ParseError(code: .missingObjectId,
                              message: "objectId must not be nil")
         }
-        let mapper = { (mapperData: Data) -> V in
+        let mapper = { @Sendable (mapperData: Data) -> V in
             var updatedObject = object
             updatedObject.originalData = nil
             updatedObject = try ParseCoding
@@ -471,7 +472,7 @@ internal extension API.Command {
             throw ParseError(code: .missingObjectId,
                              message: "objectId must not be nil")
         }
-        let mapper = { (mapperData: Data) -> V in
+        let mapper = { @Sendable (mapperData: Data) -> V in
             var updatedObject = object
             updatedObject.originalData = nil
             updatedObject = try ParseCoding
@@ -530,7 +531,7 @@ internal extension API.Command where T: ParseObject {
                                      mapper: command.mapper)
         }
 
-        let mapper = { (data: Data) -> [Result<T, ParseError>] in
+        let mapper = { @Sendable (data: Data) -> [Result<T, ParseError>] in
 
             let decodingType = [BatchResponseItem<BatchResponse>].self
             do {

Sources/ParseSwift/API/API.swift

@@ -16,11 +16,11 @@ import FoundationNetworking
 /// The REST API for communicating with a Parse Server.
 public struct API {
 
-    public enum Method: String, Encodable {
+    public enum Method: String, Encodable, Sendable {
         case GET, POST, PUT, PATCH, DELETE
     }
 
-    public enum Endpoint: Encodable {
+    public enum Endpoint: Encodable, Sendable {
         case batch
         case objects(className: String)
         case object(className: String, objectId: String)
@@ -139,7 +139,7 @@ public struct API {
     public typealias Options = Set<API.Option>
 
     /// Options available to send to Parse Server.
-    public enum Option: Hashable {
+    public enum Option: Hashable, Sendable {
 
         /// Use the primaryKey/masterKey if it was provided during initial configuraration.
         case usePrimaryKey
@@ -164,7 +164,7 @@ public struct API {
         case tags([String: String])
         /// Add context.
         /// - warning: Requires Parse Server 5.0.0+.
-        case context(Encodable)
+        case context(Encodable & Sendable)
         /// The caching policy to use for a specific http request. Determines when to
         /// return a response from the cache. See Apple's
         /// [documentation](https://developer.apple.com/documentation/foundation/url_loading_system/accessing_cached_data)

Sources/ParseSwift/API/BatchUtils.swift

@@ -23,7 +23,7 @@ typealias ParseObjectBatchResponseEncodablePointer<U> = [(Result<PointerType, Pa
 typealias RESTBatchCommandTypeEncodablePointer<T> = API.NonParseBodyCommand<ParseObjectBatchCommandEncodablePointer<T>, ParseObjectBatchResponseEncodablePointer<Encodable>> where T: Encodable
  // swiftlint:enable line_length
 
-internal struct BatchCommand<T, U>: ParseEncodable where T: ParseEncodable {
+internal struct BatchCommand<T, U>: ParseEncodable where T: ParseEncodable, U: Sendable {
     let requests: [API.Command<T, U>]
     var transaction: Bool
 }

Sources/ParseSwift/Authentication/Protocols/ParseAuthentication.swift

@@ -396,26 +396,26 @@ public extension ParseUser {
     }
 
     internal func linkCommand() async throws -> API.Command<Self, Self> {
-        var mutableSelf = self.anonymous.strip(self)
+        let strippedUser = self.anonymous.strip(self)
         if let current = try? await Self.current() {
-            guard current.hasSameObjectId(as: mutableSelf) else {
+            guard current.hasSameObjectId(as: strippedUser) else {
                 let error = ParseError(code: .otherCause,
                                        message: "Cannot signup a user with a different objectId than the current user")
                 throw error
             }
         }
         return API.Command<Self, Self>(method: .PUT,
                                        path: endpoint,
-                                       body: mutableSelf) { (data) -> Self in
+                                       body: strippedUser) { (data) -> Self in
             let user = try ParseCoding.jsonDecoder().decode(UpdateResponse.self, from: data)
-            mutableSelf = user.apply(to: mutableSelf)
+            let updatedUser = user.apply(to: strippedUser)
             if let sessionToken = user.sessionToken {
-                await Self.setCurrentContainer(.init(currentUser: mutableSelf,
+                await Self.setCurrentContainer(.init(currentUser: updatedUser,
                                                      sessionToken: sessionToken))
             } else {
-                try await Self.setCurrent(mutableSelf)
+                try await Self.setCurrent(updatedUser)
             }
-            return mutableSelf
+            return updatedUser
         }
     }
 
@@ -431,13 +431,14 @@ public extension ParseUser {
             }
             body.authData = currentAuthData
         }
+        let updatedBody = body
 
         return API.Command<SignupLoginBody, Self>(method: .PUT,
                                                   path: endpoint,
-                                                  body: body) { (data) -> Self in
+                                                  body: updatedBody) { (data) -> Self in
             let user = try ParseCoding.jsonDecoder().decode(UpdateResponse.self, from: data)
             var currentUser = user.apply(to: currentStrippedUser)
-            currentUser.authData = body.authData
+            currentUser.authData = updatedBody.authData
             if let sessionToken = user.sessionToken {
                 await Self.setCurrentContainer(.init(currentUser: currentUser,
                                                      sessionToken: sessionToken))

Sources/ParseSwift/Extensions/InputStream.swift

@@ -0,0 +1,11 @@
+//
+//  InputStream.swift
+//  ParseSwift
+//
+//  Created by Corey Baker on 7/10/24.
+//  Copyright © 2024 Network Reconnaissance Lab. All rights reserved.
+//
+
+import Foundation
+
+extension InputStream: @unchecked Sendable {}

Sources/ParseSwift/Objects/ParseInstallation.swift

@@ -747,8 +747,9 @@ extension ParseInstallation {
             let acl = try? await ParseACL.defaultACL() {
             object.ACL = acl
         }
-        let mapper = { (data) -> Self in
-            try ParseCoding.jsonDecoder().decode(CreateResponse.self, from: data).apply(to: object)
+        let updatedObject = object
+        let mapper = { @Sendable (data) -> Self in
+            try ParseCoding.jsonDecoder().decode(CreateResponse.self, from: data).apply(to: updatedObject)
         }
         return API.Command<Self, Self>(method: .POST,
                                        path: try await endpoint(.POST),
@@ -761,7 +762,7 @@ extension ParseInstallation {
             throw ParseError(code: .missingObjectId,
                              message: "objectId must not be nil")
         }
-        let mapper = { (data: Data) -> Self in
+        let mapper = { @Sendable (data: Data) -> Self in
             var updatedObject = self
             updatedObject.originalData = nil
             updatedObject = try ParseCoding.jsonDecoder().decode(ReplaceResponse.self,
@@ -786,7 +787,7 @@ extension ParseInstallation {
             throw ParseError(code: .missingObjectId,
                              message: "objectId must not be nil")
         }
-        let mapper = { (data: Data) -> Self in
+        let mapper = { @Sendable (data: Data) -> Self in
             var updatedObject = self
             updatedObject.originalData = nil
             updatedObject = try ParseCoding.jsonDecoder().decode(UpdateResponse.self,

Sources/ParseSwift/Objects/ParseUser.swift

@@ -1216,13 +1216,14 @@ extension ParseUser {
             let acl = try? await ParseACL.defaultACL() {
             user.ACL = acl
         }
-        let mapper = { (data) -> Self in
+        let updatedUser = user
+        let mapper = { @Sendable (data) -> Self in
             try ParseCoding
                 .jsonDecoder()
                 .decode(
                     CreateResponse.self,
                     from: data
-                ).apply(to: user)
+                ).apply(to: updatedUser)
         }
         let path = try await endpoint(.POST)
         let command = API.Command<Self, Self>(
@@ -1246,7 +1247,7 @@ extension ParseUser {
                 mutableSelf.email = nil
             }
         }
-        let mapper = { (data: Data) -> Self in
+        let mapper = { @Sendable (data: Data) -> Self in
             var updatedUser = self
             updatedUser.originalData = nil
             let userResponse = try ParseCoding
@@ -1301,7 +1302,7 @@ extension ParseUser {
                 mutableSelf.email = nil
             }
         }
-        let mapper = { (data: Data) -> Self in
+        let mapper = { @Sendable (data: Data) -> Self in
             var updatedUser = self
             updatedUser.originalData = nil
             let userResponse = try ParseCoding

Sources/ParseSwift/ParseConstants.swift

@@ -10,7 +10,7 @@ import Foundation
 
 enum ParseConstants {
     static let sdk = "swift"
-    static let version = "5.9.3"
+    static let version = "5.10.0"
     static let fileManagementDirectory = "parse/"
     static let fileManagementPrivateDocumentsDirectory = "Private Documents/"
     static let fileManagementLibraryDirectory = "Library/"
@@ -44,7 +44,7 @@ enum Method: String {
 /**
  The types of Parse Hook Triggers available.
  */
-public enum ParseHookTriggerType: String, Codable {
+public enum ParseHookTriggerType: String, Codable, Sendable {
     /// Occurs before login of a `ParseUser`.
     case beforeLogin
     /// Occurs after login of a `ParseUser`.

Sources/ParseSwift/Protocols/ParseEncodable.swift

@@ -12,7 +12,7 @@ import Foundation
  Types that conform to **ParseEncodable** should be encoded by the
  `ParseEncoder` when necessary.
  */
-public protocol ParseEncodable: Encodable {}
+public protocol ParseEncodable: Encodable, Sendable {}
 
 // MARK: CustomDebugStringConvertible
 extension ParseEncodable {

Sources/ParseSwift/Protocols/ParseHookFunctionable.swift

@@ -37,7 +37,7 @@ public extension ParseHookFunctionable {
 }
 
 /// A type of request for Parse Hook Functions.
-public struct FunctionRequest: Encodable {
+public struct FunctionRequest: Encodable, Sendable {
     let functionName: String
     let url: URL?
 

Sources/ParseSwift/Protocols/ParseHookParametable.swift

@@ -12,4 +12,4 @@ import Foundation
  Conforming to `ParseHookParametable` allows types that can be created
  to decode parameters in `ParseHookFunctionRequest`'s.
  */
-public protocol ParseHookParametable: Codable, Equatable {}
+public protocol ParseHookParametable: Codable, Equatable, Sendable {}

Sources/ParseSwift/Protocols/ParseHookTriggerable.swift

@@ -113,7 +113,7 @@ public extension ParseHookTriggerable {
 }
 
 /// A type of request for Parse Hook Triggers.
-public struct TriggerRequest: Encodable {
+public struct TriggerRequest: Encodable, Sendable {
     let className: String
     let trigger: ParseHookTriggerType
     let url: URL?

Sources/ParseSwift/Protocols/ParseTypeable.swift

@@ -12,6 +12,7 @@ import Foundation
  A special type that is considered a Parse type.
  */
 public protocol ParseTypeable: Codable,
+                               Sendable,
                                Equatable,
                                CustomDebugStringConvertible,
                                CustomStringConvertible {}

Sources/ParseSwift/Types/Operations/ParseOperationCommand.swift

@@ -9,7 +9,7 @@
 import Foundation
 
 /// Represents all supported Parse operation commands.
-public enum ParseOperationCommand: String, Codable {
+public enum ParseOperationCommand: String, Codable, Sendable {
     /// The add command.
     case add = "Add"
     /// The add relation command.

Sources/ParseSwift/Types/ParseACL.swift

@@ -25,7 +25,7 @@ public struct ParseACL: ParseTypeable,
     /**
      An enum specifying read and write access controls.
     */
-    public enum Access: String, Codable, CodingKey {
+    public enum Access: String, Codable, Sendable, CodingKey {
         /// Read access control.
         case read
         /// Write access control.

Sources/ParseSwift/Types/ParseField.swift

@@ -17,7 +17,7 @@ public struct ParseField: ParseTypeable {
     var targetClass: String?
 
     /// Field types available in `ParseSchema`.
-    public enum FieldType: String, Codable {
+    public enum FieldType: String, Codable, Sendable {
         /// A string type.
         case string = "String"
         /// A number type.

Sources/ParseSwift/Types/ParseHookResponse.swift

@@ -12,7 +12,7 @@ import Foundation
  Build a response after processing a `ParseHookFunctionRequest`
  or `ParseHookTriggerRequest`.
  */
-public struct ParseHookResponse<R: Codable & Equatable>: ParseTypeable {
+public struct ParseHookResponse<R: Codable & Equatable & Sendable>: ParseTypeable {
     /// The data to return in the response.
     public var success: R?
     /// An object with a Parse code and message.