feat: Supports amend transactions

[devchenyan]

issue: Magickbase/neuron-public-issues#332

default.mp4

[Danie0918]

@devchenyan Please review the above comments.

[Danie0918]

@homura @yanguoyu Please have a review.

[Danie0918]

@Keith-CY @homura Please have a review.

[silySuper]

/package

Packaging for test is done in 8994883540. @silySuper

[silySuper]

/package
Packaging for test is done in 9072896666. @silySuper

[silySuper]

Please merge latest code to this branch to sync normally @Keith-CY @devchenyan

[Keith-CY]

Please merge latest code to this branch to sync normally @Keith-CY @devchenyan

Conflicted @devchenyan

[Keith-CY]

Please merge latest code to this branch to sync normally @Keith-CY @devchenyan

Merged

[Keith-CY]

neuron-ui: Module not found: Error: Can't resolve '@nervosnetwork/ckb-sdk-utils' in '/home/runner/work/neuron/neuron/packages/neuron-ui/src/components/AmendPendingTransactionDialog'

@nervosnetwork/ckb-sdk-utils was removed by PR #3149

[silySuper]

/package
Packageing failed in 9076288137. @silySuper

[devchenyan]

/package
Packaging for test is done in 9076510260. @devchenyan

[silySuper]

send transaction shows error.

main.log

[devchenyan]

send transaction shows error.

main.log

Is this an occasional or mandatory error, I didn't encounter this error when I downloaded the package and tested it.

[silySuper]

send transaction shows error.
main.log

Is this an occasional or mandatory error, I didn't encounter this error when I downloaded the package and tested it.

In my computer ,it is appear certainly，you can watch which informantion you need to check and I will offer you to solve it.

[yanguoyu]

send transaction shows error.

main.log

It will be better to describe how to reproduce this issue. And it looks like the replace_fee is less than required.
We can export the replacement transaction and the original transaction.

[silySuper]

send transaction shows error.
main.log

It will be better to describe how to reproduce this issue. And it looks like the replace_fee is less than required. We can export the replacement transaction and the original transaction.

It was created during send transaction， I have send transaction successfully once ,then click refresh ,then send transaction again ,then show the error always,also deposit show this error too.It is not created by special operration,but by normal operation.I guess it may related to sync block.

[silySuper]

sync has problem(sync progress see this issue:nervosnetwork/ckb#4462 I watch some situations which does not need transaction confirmed.

[devchenyan]

sync has problem(sync progress see this issue:nervosnetwork/ckb#4462 I watch some situations which does not need transaction confirmed.

1、amend transaction does not support selection of unit prices
2、“Unconfirmed Outputs are allowed in the transaction” is necessary
3、Too large a fee causes outputs to be larger than inputs, so cannot submit the transaction

[Danie0918]

sync has problem(sync progress see this issue:nervosnetwork/ckb#4462 I watch some situations which does not need transaction confirmed.

1、amend transaction does not support selection of unit prices 2、“Unconfirmed Outputs are allowed in the transaction” is necessary 3、Too large a fee causes outputs to be larger than inputs, so cannot submit the transaction

1.Why is the 'Price' button not available here, and also, how is the 'Suggested price' calculated?
2,3 OK

[devchenyan]

sync has problem(sync progress see this issue:nervosnetwork/ckb#4462 I watch some situations which does not need transaction confirmed.

1、amend transaction does not support selection of unit prices 2、“Unconfirmed Outputs are allowed in the transaction” is necessary 3、Too large a fee causes outputs to be larger than inputs, so cannot submit the transaction

1.Why is the 'Price' button not available here, and also, how is the 'Suggested price' calculated? 2,3 OK

sync has problem(sync progress see this issue:nervosnetwork/ckb#4462 I watch some situations which does not need transaction confirmed.

1、amend transaction does not support selection of unit prices 2、“Unconfirmed Outputs are allowed in the transaction” is necessary 3、Too large a fee causes outputs to be larger than inputs, so cannot submit the transaction

1.Why is the 'Price' button not available here, and also, how is the 'Suggested price' calculated? 2,3 OK

Because it is recommended that the price options routinely suggested are likely to be lower than the price needed to amend the transaction.And the user does not need to amend the suggested price by himself.

Get min_replace_fee via api and calculate it with the size of the transaction to get the 'Suggested price'

[Danie0918]

sync has problem(sync progress see this issue:nervosnetwork/ckb#4462 I watch some situations which does not need transaction confirmed.

1、amend transaction does not support selection of unit prices 2、“Unconfirmed Outputs are allowed in the transaction” is necessary 3、Too large a fee causes outputs to be larger than inputs, so cannot submit the transaction

1.Why is the 'Price' button not available here, and also, how is the 'Suggested price' calculated? 2,3 OK

sync has problem(sync progress see this issue:nervosnetwork/ckb#4462 I watch some situations which does not need transaction confirmed.

1、amend transaction does not support selection of unit prices 2、“Unconfirmed Outputs are allowed in the transaction” is necessary 3、Too large a fee causes outputs to be larger than inputs, so cannot submit the transaction

1.Why is the 'Price' button not available here, and also, how is the 'Suggested price' calculated? 2,3 OK

Because it is recommended that the price options routinely suggested are likely to be lower than the price needed to amend the transaction.And the user does not need to amend the suggested price by himself.

Get min_replace_fee via api and calculate it with the size of the transaction to get the 'Suggested price'

OK.

[silySuper]

In cell management:
1.when click submit the transaction,transaction hash is null ,but can copy,copy result is undefined.

[devchenyan]

In cell management: 1.when click submit the transaction,transaction hash is null ,but can copy,copy result is undefined.

fixed @silySuper

[devchenyan]

/package
Packaging for test is done in 9121303973. @devchenyan

[silySuper]

In Nervos Dao:
withdraw/create account amend can only be operated once,when amend twice it shows

unlock does not see amend button.

[devchenyan]

In Nervos Dao: withdraw/create account amend can only be operated once,when amend twice it shows

unlock does not see amend button.

1. withdraw/create account amend can amend twice. Please make sure that the amend tx is new transaction, as the amended transaction will fail and be removed.
   

Screen-2024-05-17-113455.mp4

2. The type of Unlcok is 'receive'. The treatment condition inputs-fee=outputs is not satisfied

[silySuper]

/package
Packaging for test is done in 9152602959. @silySuper

[silySuper]

In Nervos Dao: withdraw/create account amend can only be operated once,when amend twice it shows
unlock does not see amend button.

1. withdraw/create account amend can amend twice. Please make sure that the amend tx is new transaction, as the amended transaction will fail and be removed.
   

Screen-2024-05-17-113455.mp4
2. The type of Unlcok is 'receive'. The treatment condition inputs-fee=outputs is not satisfied

For the first problem,your video is different from mine.My operation is clicking amend when status is pending on amend transaction(not the first transaction). I guess is the status is failed in db,but shows pending in page cause this problem,so you can click amend but cannot fill in amend data.This can be considered to optimize when you are convenient later.