fix: comments

nervosnetwork · May 13, 2024 · d8f0cff · d8f0cff · github-actions · May 13, 2024
1 parent 2c92bb4
commit d8f0cff
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 8 deletions.
diff --git a/packages/neuron-ui/src/components/AmendPendingTransactionDialog/hooks.ts b/packages/neuron-ui/src/components/AmendPendingTransactionDialog/hooks.ts
@@ -223,7 +223,7 @@ export const useOutputs = ({
 
       return inputsCapacity - outputsCapacity - fee
     }
-    return -1
+    return undefined
   }, [transaction, fee, outputsCapacity])
 
   return {

diff --git a/packages/neuron-ui/src/components/AmendPendingTransactionDialog/index.tsx b/packages/neuron-ui/src/components/AmendPendingTransactionDialog/index.tsx
@@ -66,7 +66,7 @@ const AmendPendingTransactionDialog = ({ tx, onClose }: { tx: State.Transaction;
   )
 
   useEffect(() => {
-    if (transaction) {
+    if (transaction && lastOutputsCapacity !== undefined) {
       const outputs = items.map(item => {
         const capacity = item.isLastOutput ? lastOutputsCapacity.toString() : item.capacity
         if (item.output.data === DAO_DATA) {
@@ -86,7 +86,13 @@ const AmendPendingTransactionDialog = ({ tx, onClose }: { tx: State.Transaction;
     }
   }, [lastOutputsCapacity, transaction, items, setGeneratedTx])
 
-  const disabled = !!(isSending || !generatedTx || priceError || lastOutputsCapacity < MIN_AMOUNT)
+  const disabled = !!(
+    isSending ||
+    !generatedTx ||
+    priceError ||
+    lastOutputsCapacity === undefined ||
+    lastOutputsCapacity < MIN_AMOUNT
+  )
 
   return (
     <>

diff --git a/packages/neuron-ui/src/components/AmendSUDTSend/index.tsx b/packages/neuron-ui/src/components/AmendSUDTSend/index.tsx
@@ -105,7 +105,7 @@ const AmendSUDTSend = () => {
   }, [transaction?.outputs])
 
   useEffect(() => {
-    if (transaction) {
+    if (transaction && lastOutputsCapacity !== undefined) {
       const outputs = items.map(item => {
         const capacity = item.isLastOutput ? lastOutputsCapacity.toString() : item.capacity
         return {
@@ -126,7 +126,8 @@ const AmendSUDTSend = () => {
     }
   }, [lastOutputsCapacity, transaction, items, dispatch, experimental?.params?.description, description])
 
-  const disabled = sending || !experimental?.tx || priceError || lastOutputsCapacity < 0
+  const disabled =
+    sending || !experimental?.tx || priceError || lastOutputsCapacity === undefined || lastOutputsCapacity < 0
 
   return (
     <PageContainer

diff --git a/packages/neuron-ui/src/components/AmendSend/index.tsx b/packages/neuron-ui/src/components/AmendSend/index.tsx
@@ -136,11 +136,11 @@ const AmendSend = () => {
 
       return inputsCapacity - outputsCapacity - fee
     }
-    return -1
+    return undefined
   }, [transaction, fee, outputsCapacity])
 
   useEffect(() => {
-    if (transaction) {
+    if (transaction && lastOutputsCapacity !== undefined) {
       const outputs = items.map(item => {
         const capacity = item.isLastOutput ? lastOutputsCapacity.toString() : item.capacity
         return {
@@ -158,7 +158,8 @@ const AmendSend = () => {
     }
   }, [lastOutputsCapacity, transaction, items, dispatch])
 
-  const disabled = sending || !send.generatedTx || priceError || lastOutputsCapacity < MIN_AMOUNT
+  const disabled =
+    sending || !send.generatedTx || priceError || lastOutputsCapacity === undefined || lastOutputsCapacity < MIN_AMOUNT
 
   return (
     <PageContainer