Add generic rule for adding comments to fusion prototype usage #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dlubitz
commented
Apr 21, 2024
dlubitz
commented
- Add rule for adding comments to used Prototypes.
- Replace dedicated Neos.Neos:PrimaryContent rule with generic rule
- Add comments for Neos.Fusion:Attributes
Replace dedicated Neos.Neos:PrimaryContent rule with generic rule Add comments for Neos.Fusion:Attributes
bwaidelich
approved these changes
Apr 21, 2024
|
Ok, so this PR broke If I go back one commit, it works. |
dlubitz
commented
May 14, 2024
| */ | ||
| $rectorConfig->rule(FusionPrimaryContentRector::class); | ||
| $rectorConfig->ruleWithConfiguration(FusionPrototypeNameAddComment::class, [ |
There was a problem hiding this comment.
@kdambekalns Yeah, sorry. AFAIS there is wrong class used:
This needs to be: FusionPrototypeNameAddCommentRector::class
There was a problem hiding this comment.
It's pretty sh**ty, that the tests are not covering the "real" configuration.
There was a problem hiding this comment.
Yep, creating a PR right now…
|
@kdambekalns with the hard pinned rector version of the package? |
kdambekalns
added a commit
that referenced
this pull request
May 14, 2024
Fixes an error that slipped in with #52: ``` [ERROR] Expected an instance of this class or to this class among its parents "Rector\Core\Contract\Rector\RectorInterface". Got: "Neos\Rector\Generic\ValueObject\FusionPrototypeNameAddComment" in /…/Packages/Libraries/neos/rector/src/../config/set/contentrepository-90.php (which is being imported from "/…/rector.php"). ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.