Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace removed Fusion prototypes #50

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Apr 12, 2024

Replaces Fusion prototypes regarding this list:

  • Neos.Fusion:Array replaced with Neos.Fusion:Join

  • Neos.Fusion:RawArray replaced with Neos.Fusion:DataStructure

  • Neos.Fusion:Collection replaced with Neos.Fusion:Loop

  • Neos.Fusion:RawCollection replaced with Neos.Fusion:Map

https://github.com/neos/neos-development-collection/blob/9.0/Neos.Neos/Documentation/References/NeosFusionReference.rst?plain=1#L1377-L1384

Fixes #47

@dlubitz dlubitz self-assigned this Apr 12, 2024
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 by 👀

Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, +1 by reading

@bwaidelich bwaidelich merged commit 0ed18d8 into main Apr 17, 2024
2 checks passed
@bwaidelich bwaidelich deleted the removed-fusion-prototypes branch April 17, 2024 08:45
@mhsdesign
Copy link
Member

hi thanks for this pr but as @mficzel and me discussed we need to have a comment explaining the full implications of this rename as the keys cannot be migrated safely. A comment like neos/neos-development-collection#4537 (comment)

# @todo the key `children` has to be renamed to `items` which cannot be done automatically

might help?

also Neos.Fusion:Attributes was removed without replacement.

The full upgrade instruction can also be found inside the pr:

  • Neos.Fusion:Array replace with Neos.Fusion:Join
  • Neos.Fusion:RawArray replaced with Neos.Fusion:DataStructure
  • Neos.Fusion:Collection replaced with Neos.Fusion:Loop and the property children has to be renamed to items
  • Neos.Fusion:RawCollection replaced with Neos.Fusion:Map and the property children has to be renamed to items
  • Neos.Fusion:Attributes replaced by the property attributes in Neos.Fusion:Tag

@dlubitz
Copy link
Contributor Author

dlubitz commented Apr 21, 2024

@mhsdesign See #51

@dlubitz
Copy link
Contributor Author

dlubitz commented Apr 21, 2024

@mhsdesign and see #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

exchange Neos.Fusion:RawArray and Neos.Fusion:Attributes prototypes
4 participants