-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created github actions(#11) for building source code and testing it #75
Conversation
@preston-rogers Is this ready for merge? It would be awesome to get the action setup and working |
Hey @japrozs, please let me know if you need further information. I will add the necessary changes to pass CI by EOD Thursday PST otherwise. |
i think the PR is good to merge 👍🏼 |
Hello @japrozs. After testing your changes, the actions fail partly due to a variable unused warnings and because the chosen valgrind was failing on the ubuntu 22.04 runner. I made the necessary modifications in the following PR. Please merge this in and once that is done, I'm happy to merge this into the main JSD repo. |
yep, i merged the PR. thanks for fixing the issues 👍🏼 |
No problem! My fault, but could you make a new PR trying to merge the master branch of your forked repo into the master branch of nasa-jpl? Accidentally made the necessary changes on your master branch. |
yeah; i’ll create a new PR with the changes |
@preston-rogers here you go – #91 |
added github actions for CI – #11