Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created github actions(#11) for building source code and testing it #75

Closed
wants to merge 5 commits into from
Closed

created github actions(#11) for building source code and testing it #75

wants to merge 5 commits into from

Conversation

japrozs
Copy link
Contributor

@japrozs japrozs commented May 3, 2023

added github actions for CI – #11

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
@alex-brinkman
Copy link
Contributor

@preston-rogers Is this ready for merge? It would be awesome to get the action setup and working

@preston-rogers
Copy link
Contributor

Hey @japrozs, please let me know if you need further information. I will add the necessary changes to pass CI by EOD Thursday PST otherwise.

@japrozs
Copy link
Contributor Author

japrozs commented Jun 15, 2023

Hey @japrozs, please let me know if you need further information. I will add the necessary changes to pass CI by EOD Thursday PST otherwise.

i think the PR is good to merge 👍🏼

@preston-rogers
Copy link
Contributor

Hello @japrozs. After testing your changes, the actions fail partly due to a variable unused warnings and because the chosen valgrind was failing on the ubuntu 22.04 runner. I made the necessary modifications in the following PR. Please merge this in and once that is done, I'm happy to merge this into the main JSD repo.
https://github.com/japrozs/jsd/pull/1

@japrozs
Copy link
Contributor Author

japrozs commented Jun 20, 2023

Hello @japrozs. After testing your changes, the actions fail partly due to a variable unused warnings and because the chosen valgrind was failing on the ubuntu 22.04 runner. I made the necessary modifications in the following PR. Please merge this in and once that is done, I'm happy to merge this into the main JSD repo. japrozs#1

yep, i merged the PR. thanks for fixing the issues 👍🏼

@japrozs japrozs requested a review from preston-rogers June 20, 2023 18:20
@preston-rogers
Copy link
Contributor

preston-rogers commented Jun 20, 2023

Hello @japrozs. After testing your changes, the actions fail partly due to a variable unused warnings and because the chosen valgrind was failing on the ubuntu 22.04 runner. I made the necessary modifications in the following PR. Please merge this in and once that is done, I'm happy to merge this into the main JSD repo. japrozs#1

yep, i merged the PR. thanks for fixing the issues 👍🏼

No problem! My fault, but could you make a new PR trying to merge the master branch of your forked repo into the master branch of nasa-jpl? Accidentally made the necessary changes on your master branch.
After the new PR is created please delete this one.

@japrozs
Copy link
Contributor Author

japrozs commented Jun 21, 2023

yeah; i’ll create a new PR with the changes

@japrozs japrozs closed this by deleting the head repository Jun 21, 2023
@japrozs
Copy link
Contributor Author

japrozs commented Jun 21, 2023

Hello @japrozs. After testing your changes, the actions fail partly due to a variable unused warnings and because the chosen valgrind was failing on the ubuntu 22.04 runner. I made the necessary modifications in the following PR. Please merge this in and once that is done, I'm happy to merge this into the main JSD repo. japrozs#1

yep, i merged the PR. thanks for fixing the issues 👍🏼

No problem! My fault, but could you make a new PR trying to merge the master branch of your forked repo into the master branch of nasa-jpl? Accidentally made the necessary changes on your master branch. After the new PR is created please delete this one.

@preston-rogers here you go – #91

@preston-rogers
Copy link
Contributor

preston-rogers commented Jun 21, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants