Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pydantic 2 compatibility layer #321

Merged
merged 9 commits into from
Oct 20, 2023
Merged

Add pydantic 2 compatibility layer #321

merged 9 commits into from
Oct 20, 2023

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Oct 19, 2023

allow to use with pydantic 2

napari/napari#6350

@Czaki Czaki requested a review from tlambert03 October 19, 2023 17:15
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #321 (a7f2684) into main (8c58b91) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #321   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          37       38    +1     
  Lines        2814     2814           
=======================================
  Hits         2807     2807           
  Misses          7        7           
Files Coverage Δ
src/npe2/_dynamic_plugin.py 100.00% <100.00%> (ø)
src/npe2/_pydantic_compat.py 100.00% <100.00%> (ø)
src/npe2/implements.py 100.00% <100.00%> (ø)
src/npe2/manifest/_bases.py 100.00% <100.00%> (ø)
src/npe2/manifest/_package_metadata.py 100.00% <100.00%> (ø)
src/npe2/manifest/contributions/_commands.py 100.00% <100.00%> (ø)
src/npe2/manifest/contributions/_configuration.py 100.00% <100.00%> (ø)
src/npe2/manifest/contributions/_contributions.py 100.00% <100.00%> (ø)
src/npe2/manifest/contributions/_icon.py 100.00% <100.00%> (ø)
src/npe2/manifest/contributions/_json_schema.py 100.00% <100.00%> (ø)
... and 9 more

@Czaki Czaki requested a review from nclack October 19, 2023 22:26
@psobolewskiPhD psobolewskiPhD changed the title Add pydantic 2 comaptybility layer Add pydantic 2 compatibility layer Oct 20, 2023
@Czaki Czaki requested a review from jni October 20, 2023 07:33
Copy link
Contributor

@brisvag brisvag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and straightforward, love it!

@Czaki Czaki merged commit 9d29e4d into napari:main Oct 20, 2023
31 checks passed
@Czaki Czaki deleted the pydantic_2 branch October 20, 2023 13:53
VolkerH added a commit to VolkerH/npe2 that referenced this pull request Nov 6, 2023
Add pydantic 2 compatibility layer (napari#321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants