Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create npe2.yaml to patch (remove) pydantic pin #678

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

psobolewskiPhD
Copy link
Member

@psobolewskiPhD psobolewskiPhD commented Mar 9, 2024

In napari/npe2#321 the pydantic < 2 pin was dropped from npe2 but it was missed here, so the conda-forge package still requires pydantic 1.
0.7.3 and 0.7.4 shouldn't have pydantic upper bound.

See also: conda-forge/npe2-feedstock#20
closes: napari/npe2#343

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

@psobolewskiPhD psobolewskiPhD requested a review from a team as a code owner March 9, 2024 20:48
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@psobolewskiPhD
Copy link
Member Author

BTW i love the new yaml way of doing this! So much simpler and less intimidating! Kudos to y'all!

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Mar 9, 2024

Patch difference:

noarch
noarch::npe2-0.7.4-pyhd8ed1ab_0.conda
noarch::npe2-0.7.3-pyhd8ed1ab_0.conda
-    "pydantic <2.0a0",
+    "pydantic",

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Mar 9, 2024

BTW i love the new yaml way of doing this! So much simpler and less intimidating! Kudos to y'all!

this was all @beckermr

I now use Chatgpt and english to write these patches...

@psobolewskiPhD
Copy link
Member Author

psobolewskiPhD commented Mar 9, 2024

I now use Chatgpt and english to write these patches...

Wait, what? 🤯

Edit: sorry I didn't post the diff, I didn't realize that still applied. my bad.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Mar 9, 2024

Wait, what? 🤯

Yeha, i copy pasted the readme, and just told chatgpt to figure out how to fix my stuff. It might even be able to figure out the timestamp portion, but i still make that one manually!

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Mar 9, 2024

Sorry, i'm just pretty excited about the removal of the pydantic v1 pin. That transition was painful on everybody i think...

@hmaarrfk hmaarrfk merged commit d2b4b29 into conda-forge:main Mar 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong pydantic version pin on conda-forge?
2 participants