Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Add doc in CommandRegistry about when it is updated #316

Merged
merged 6 commits into from
Oct 13, 2023
Merged

DOC Add doc in CommandRegistry about when it is updated #316

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
180d22e
add doc in command reg
lucyleeow Oct 10, 2023
d6f437e
style: [pre-commit.ci] auto fixes [...]
pre-commit-ci[bot] Oct 10, 2023
252df54
typo
lucyleeow Oct 10, 2023
684355b
Update src/npe2/_command_registry.py
lucyleeow Oct 11, 2023
196ee60
Update src/npe2/_command_registry.py
lucyleeow Oct 11, 2023
ed17201
Merge branch 'main' into doc_reg
nclack Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/npe2/_command_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ def resolve(self) -> Callable:


class CommandRegistry:
"""Registry of commands, updated when `PluginManager.activate` run.
lucyleeow marked this conversation as resolved.
Show resolved Hide resolved

`PluginManager.activate` is only run on `CommandRegistry.get` (when we get the
lucyleeow marked this conversation as resolved.
Show resolved Hide resolved
callable object for a command). This means that commands from enabled plugins are
not added to `CommandRegistry` until a command from that plugin is executed.
"""

command_registered = Signal(str)
command_unregistered = Signal(str)

Expand Down
Loading