Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Add doc in CommandRegistry about when it is updated #316

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

lucyleeow
Copy link
Contributor

Adds some info about when CommandRegistry is updated. Uses info learned when debugging #314

Happy to change wording or move to a better place.

@lucyleeow
Copy link
Contributor Author

cc @DragaDoncila

@lucyleeow
Copy link
Contributor Author

I don't think the CI failures are related to this doc change.

Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, thanks @lucyleeow 🙏

src/npe2/_command_registry.py Outdated Show resolved Hide resolved
src/npe2/_command_registry.py Outdated Show resolved Hide resolved
@DragaDoncila
Copy link
Contributor

Looks like our codecov token might have expired, or something:

[2023-10-10T02:14:55.728Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:]
(https://codecov.io/) Error: There was an error fetching the storage URL during POST: 400 - [ErrorDetail(string='This 
repository has been deactivated. To resume uploading to it, please activate the repository in the codecov UI: 
https://app.codecov.io/github/napari/npe2/settings', code='invalid')]

@Czaki do you know what I'd need to do to fix this?

lucyleeow and others added 2 commits October 11, 2023 17:33
@lucyleeow
Copy link
Contributor Author

Thanks changes made!

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #316 (ed17201) into main (cb5ba4a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          37       37           
  Lines        2814     2814           
=======================================
  Hits         2807     2807           
  Misses          7        7           
Files Coverage Δ
src/npe2/_command_registry.py 100.00% <ø> (ø)

@nclack nclack merged commit fad71d8 into napari:main Oct 13, 2023
18 checks passed
@lucyleeow lucyleeow deleted the doc_reg branch October 13, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants