Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P11 config update #1095

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions mxcubecore/configuration/desy_p11/_Qt4_video-mockup.xml

This file was deleted.

2 changes: 0 additions & 2 deletions mxcubecore/configuration/desy_p11/attenuators-mockup.xml

This file was deleted.

12 changes: 12 additions & 0 deletions mxcubecore/configuration/desy_p11/backlight.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@

<device class="P11BackLight">
<username>BackLight</username>

<tangoname>p11/register/eh.o.3.05</tangoname>

<open_time>8</open_time>
<close_time>4</close_time>

<channel type="tango" name="value" polling="500">value</channel>

</device>
6 changes: 0 additions & 6 deletions mxcubecore/configuration/desy_p11/beam-info.xml

This file was deleted.

8 changes: 8 additions & 0 deletions mxcubecore/configuration/desy_p11/beam-mockup.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<object class="BeamMockup">
<device hwrid="/diff-aperture-mockup" role="aperture"/>
<device hwrid="/slits-mockup" role="slits"/>
<beam_position>340,256</beam_position>
<beam_divergence_horizontal>12.0</beam_divergence_horizontal>
<beam_divergence_vertical>12.0</beam_divergence_vertical>
</object>

12 changes: 12 additions & 0 deletions mxcubecore/configuration/desy_p11/beam.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<object class="P11Beam">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should be DESY.P11Beam, as the file is in the DESY sub directory.

<device hwrid="/diff-aperture-mockup" role="aperture"/>
<device hwrid="/slits-mockup" role="slits"/>

<channel type="tango" tangoname="p11/energy/1" name="beamsize" polling="500">BeamSize</channel>
<channel type="tango" tangoname="p11/energy/1" name="state" polling="500">State</channel>

<beam_divergence_vertical>0.05</beam_divergence_vertical>
<beam_divergence_horizontal>0.05</beam_divergence_horizontal>
<definer_type>"mirror"</definer_type>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if you have a definer mirror, than you should be having an object with a role mirror (just like aperture and slits)

</object>

107 changes: 0 additions & 107 deletions mxcubecore/configuration/desy_p11/beamline-setup.xml

This file was deleted.

1 change: 0 additions & 1 deletion mxcubecore/configuration/desy_p11/beamline-test.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<object class="BeamlineTestMockup">
<object href="/beamline-setup" role="beamline_setup"/>

<available_tests>["example_one", "example_two"]</available_tests>
<startup_tests>["example_one"]</startup_tests>
Expand Down
122 changes: 122 additions & 0 deletions mxcubecore/configuration/desy_p11/beamline_config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
# The class to initialise, and init parameters
_initialise_class:

Check warning on line 2 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

2:1 [document-start] missing document start "---"
class: mxcubecore.HardwareObjects.Beamline.Beamline

Check failure on line 3 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

3:5 [indentation] wrong indentation: expected 2 but found 4
# Further key-value pairs here will be passed to the class init
# mode: devel

# objects
#
# Eventually all objects should use the yaml config system like Beamline,
# but for now we can leave them as xml
#
# NBNB some objects that do not currently have their own config files
# would need those added (e.g. the centring methods)
#
_objects:
# The !!o0map and the lines starting with '- ' give you an *ordered* dictionary
# And thus a reproducible loading order
!!omap

Check failure on line 18 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

18:5 [indentation] wrong indentation: expected 2 but found 4
# The values are the file paths to the configuration file for the
# object, relative to the configuration file path(s)
#
# NB - the order is *NOT* arbitrary, as signal connnections are set
# on one object that require the other to be already loaded.
#
# Hardware:
- session: session.xml

Check failure on line 26 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

26:5 [indentation] wrong indentation: expected 2 but found 4
- machine_info: mach-info.xml
- transmission: transmission.xml
- energy: energy.xml
- beam: beam.xml
- flux: flux.xml
- detector: eiger.xml
- resolution: resolution.xml
- hutch_interlock: door-interlock.xml
- safety_shutter: shutter-eh.xml
- fast_shutter: fast-shutter.xml
- sample_changer: sample-changer.xml
# - sample_changer: sc-mockup.xml
# NBNB TODO remove plate_manipulater and treat as another smaple changer
# - plate_manipulator: plate-manipulator-mockup.xml
- diffractometer: nanodiff.xml
- sample_view: sample-view.xml
- lims: lims.xml
- queue_manager: queue.xml
- queue_model: queue-model.xml
# Procedures:
- collect: mxcollect.xml
#- xrf_spectrum: xrf-spectrum-mockup.xml

Check warning on line 48 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

48:6 [comments] missing starting space in comment
- energy_scan: energyscan-mockup.xml
# - imaging: xray-imaging.xml # Only in EMBL as of 201907

Check warning on line 50 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

50:1 [comments-indentation] comment not indented like content
#- gphl_workflow: gphl-workflow.xml

Check warning on line 51 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

51:6 [comments] missing starting space in comment
#- gphl_connection: gphl-setup.xml

Check warning on line 52 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

52:6 [comments] missing starting space in comment
# - centring: centring.xml
# Analysis:
- offline_processing: offline-processing-mockup.xml
- online_processing: online-processing-mockup.xml
- characterisation: characterisation.xml
# - beam_realign: # Skipped - optional
# Non-object attributes:
advanced_methods:
- MeshScan
- XrayCentering
tunable_wavelength: true
disable_num_passes: false
run_online_processing: false
run_number: 1

default_acquisition_parameters:
default:

Check failure on line 69 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

69:5 [indentation] wrong indentation: expected 2 but found 4
# Default values, also used for standard acquisition.
# Values not given in other dictionaries are taken from here
exp_time: 0.01 # (s) exposure time

Check failure on line 72 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

72:9 [indentation] wrong indentation: expected 6 but found 8
osc_start: 0.0 # (degrees) Only used if no current angle found
osc_range: 0.1 # (degrees)
num_passes: 1 # (int)
first_image: 1 # (int)
overlap: 0
num_images: 3600 # (int)
# detector_binning_mode: 1 # Removed as not in practice used.
inverse_beam: false # (bool)
take_dark_current: true # (bool)
skip_existing_images: true # (bool)
take_snapshots: false # (bool)

helical:
# Defaults for helical scan. Missing values are taken from default
num_images: 100

Check failure on line 87 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

87:9 [indentation] wrong indentation: expected 6 but found 8

characterisation:
# Defaults for chareacterisation. Missing values are taken from default
exp_time: 0.05

Check failure on line 91 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

91:9 [indentation] wrong indentation: expected 6 but found 8
osc_start: 0.0
osc_range: 1.0
opt_sad: False

Check warning on line 94 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

94:18 [truthy] truthy value should be one of [false, true]
account_rad_damage: True

Check warning on line 95 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

95:29 [truthy] truthy value should be one of [false, true]
strategy_complexity: 0
max_crystal_vd:im: 1.0
min_crystal_vdim: 1.0
max_crystal_vphi: 1.0
min_crystal_vphi: 1.0

advanced:
# Defaults for 'advanced' acquisition. Missing values are taken from default
osc_range: 0.5

Check failure on line 104 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

104:9 [indentation] wrong indentation: expected 6 but found 8
num_images: 100

acquisition_limit_values:
exposure_time: # (s)

Check failure on line 108 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

108:5 [indentation] wrong indentation: expected 2 but found 4
- 0.007

Check failure on line 109 in mxcubecore/configuration/desy_p11/beamline_config.yml

View workflow job for this annotation

GitHub Actions / pre-commit

109:9 [indentation] wrong indentation: expected 6 but found 8
- 6000.0
osc_range: # (degrees)
- -1000
- 1000
number_of_images: # (int)
- 1
- 99999
# kappa: # (degrees)
# - 0.0
# - 180.0
# kappa_phi: # (degrees)
# - 0.0
# - 360.0
5 changes: 0 additions & 5 deletions mxcubecore/configuration/desy_p11/beamstop-mockup.xml

This file was deleted.

10 changes: 10 additions & 0 deletions mxcubecore/configuration/desy_p11/beamstop.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<device class="P11BeamStop">
<username>BeamStop</username>
<motorlist>bstopx</motorlist>

<object role="bstopx" href="/bstopx" />

<delta_bstopx>1</delta_bstopx>

<values>{"in": {"bstopx": 27000}, "out": {"bstopx": 69000}}</values>
</device>
14 changes: 14 additions & 0 deletions mxcubecore/configuration/desy_p11/beamstop_bcp.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<device class="P11BeamStop">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, should not this be DESY.P11BeamStop

<username>BeamStop</username>
<motorlist>bstopx, bstopy, bstopz</motorlist>

<object role="bstopx" href="/bstopx" />
<object role="bstopy" href="/bstopy" />
<object role="bstopz" href="/bstopz" />

<delta_bstopx>1</delta_bstopx>
<delta_bstopy>100</delta_bstopy>
<delta_bstopz>100</delta_bstopz>

<values>{"in": {"bstopx": 27000, "bstopy": -136, "bstopz": -135}, "out": {"bstopx": 69000, "bstopy": -136, "bstopz": -135}}</values>
</device>
9 changes: 9 additions & 0 deletions mxcubecore/configuration/desy_p11/bstopx.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<device class="TangoMotor">
<actuator_name>bstopx</actuator_name>
<username>BeamStop X</username>

<tangoname>p11/motor/eh.3.09</tangoname>

<command type="tango" name="stopAxis">StopMove</command>
<channel type="tango" name="axisState" polling="500">State</channel>
</device>
9 changes: 9 additions & 0 deletions mxcubecore/configuration/desy_p11/bstopy.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<device class="TangoMotor">
<actuator_name>bstopy</actuator_name>
<username>BeamStop Y</username>

<tangoname>p11/piezomotor/eh.4.09</tangoname>

<command type="tango" name="stopAxis">Stop</command>
<channel type="tango" name="axisState" polling="500">State</channel>
</device>
9 changes: 9 additions & 0 deletions mxcubecore/configuration/desy_p11/bstopz.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<device class="TangoMotor">
<actuator_name>bstopz</actuator_name>
<username>BeamStop Z</username>

<tangoname>p11/piezomotor/eh.4.10</tangoname>

<command type="tango" name="stopAxis">Stop</command>
<channel type="tango" name="axisState" polling="500">State</channel>
</device>
5 changes: 0 additions & 5 deletions mxcubecore/configuration/desy_p11/camera.xml

This file was deleted.

33 changes: 0 additions & 33 deletions mxcubecore/configuration/desy_p11/cats.xml

This file was deleted.

Loading
Loading