P11 config update #1095
P11 config update #1095
Conversation
There was a problem hiding this comment.
Hi @agruzinov, good initiative to clean up obsolete files.
As a general remark, we have removed Device and Equipment classes, so everywhere in the config files you should replace device and equipment with object. It still works if you do not do this, but since you are anyhow cleaning up, it will be better if you do it. Also will be easier when you transfer from xml to yaml.
| @@ -0,0 +1,12 @@ | |||
| <object class="P11Beam"> | |||
There was a problem hiding this comment.
This probably should be DESY.P11Beam, as the file is in the DESY sub directory.
|
|
||
| <beam_divergence_vertical>0.05</beam_divergence_vertical> | ||
| <beam_divergence_horizontal>0.05</beam_divergence_horizontal> | ||
| <definer_type>"mirror"</definer_type> |
There was a problem hiding this comment.
I wonder if you have a definer mirror, than you should be having an object with a role mirror (just like aperture and slits)
| @@ -0,0 +1,14 @@ | |||
| <device class="P11BeamStop"> | |||
There was a problem hiding this comment.
Same as above, should not this be DESY.P11BeamStop
| @@ -0,0 +1,5 @@ | |||
| <object class="P11EDNACharacterisation"> | |||
There was a problem hiding this comment.
Same as above (DESY.P11EDNACharacterisation)
| @@ -0,0 +1,14 @@ | |||
| <object class="P11Collimator"> | |||
| <device class="ApertureMockup"> | ||
| </device> |
There was a problem hiding this comment.
This should be as before - object, not device
| <device class="MotorMockup"> | ||
| <actuator_name>Kappa</actuator_name> | ||
| </object> | ||
| </device> |
| <device class="MotorMockup"> | ||
| <actuator_name>Phi</actuator_name> | ||
| </object> | ||
| </device> |
There was a problem hiding this comment.
Revert to previous version - should be object, not device
| <device class = "P11DoorInterlock"> | ||
| </device> |
There was a problem hiding this comment.
object and also DESY.P11DoorInterlock
| @@ -0,0 +1,11 @@ | |||
| <equipment class="P11Energy"> | |||
There was a problem hiding this comment.
object, not equipment, also DESY.P11Energy
|
Thanks for the comments @beteva! I was wondering if someone is using the yamllinter that can lint files and not only show errors that needs to be changed one by one :) |
I had a very quick look at the job output. Looks like the YAML files have a lot of "long lines". It is possible to disable the "long lines" rule for a specific file. That would be acceptable, especially since it appears in DESY-specific files, it is up to DESY to maintain those files and possibly disable all linting rules for those files if it is what is wanted. https://yamllint.readthedocs.io/en/stable/disable_with_comments.html |
|
@agruzinov, unfortunately I don't think there is formater that handles all the linting errors. I tried to find one a while back and I did not find any at the time. Perhaps someone out there have found a good tool ? |
Before starting migration to the yaml it is good to have working set of scripts for the current setup.