Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct tempo for metronome marking #14678 #24840

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rpatters1
Copy link

@rpatters1 rpatters1 commented Sep 20, 2024

Resolves: #14678

When creating a new document, the tempo was not changed to match the metronome marking. Instead, the tempo always was the tempo for quarter notes. (See #14678.) This change corrects that.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@rpatters1 rpatters1 changed the title Set correct tempo for metronome marking #21458 Set correct tempo for metronome marking #14678 Sep 20, 2024
@Jojo-Schmitz
Copy link
Contributor

What about #21458 ?

@rpatters1
Copy link
Author

I worked on it because it was unassigned. Merge one and close the other. It looks like either gets the job done.

@cbjeukendrup
Copy link
Contributor

@rpatters1 For in the future: if there is already a PR for an issue, this is indicated on the issue page:
Scherm­afbeelding 2024-09-20 om 19 33 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants