Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14678: Tempo set in New Score other than quarter note doesn't reflect supposed BPM #21458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CoolSpy3
Copy link

@CoolSpy3 CoolSpy3 commented Feb 12, 2024

Resolves: #14678

Resolves a bug where new scores would not have the correct tempo marking when a non-quarter-note tempo was specified. This is accomplished by correcting the implementation of the MasterNotation::applyOptions method. When setting the tempo of the score, we use the tempo's duration option to scale the bpm value so that it is in units of "Quarter Notes / Second" rather than "Duration / Second".

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

I don't know enough about this repository to write unit tests for this change. If maintainers feel that these changes necessitate unit tests, please point me in the direction of some similar samples and/or documentation, and I'll see what I can do.

@Jojo-Schmitz
Copy link
Contributor

See also #24840 now

@rpatters1
Copy link

I worked on it because it was unassigned. Take your pick and close the other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants